Ruslan Kardashev yes this ss what every tutorial says. If subscribing from angular components, they are auto unsub.

Yeah http observables complete after delivery

I was just asking myself, why does he subscribe for http request?? And I see your comment 😁

Yeah! Why nobody told this guy that the share operator exists :D

​@@artemeelemann317 Well, his proposal is a much smaller foot print. 2 separate data streams get combined into one. The dom that requires the second data piece will not always render because the first data piece comes in. So you make that dom dependant on that piece of data...Which forces you to rewrite your data to conform to say an object. And now you have action dispatch pattern you have to enforce on two disparate pieces of data. you could probably use it the observable to update a class attribute but then you'd end up withe same amount of code now as you had with method 2 (controller based observer management) Whereas, he is proposing that each variable is reactive and you call that render on just an ngIf in the view template. Its harder to make bad code with his protototype. If you want to nitpick, I would go for the fact that everybody wants to be that final class which is why he recommends integration with akita. This is a data component level final class and not a layout final class. You'd most likely wrap your ui library with a data-reactive-component and serve it into a layout view Its a lot less code. But i doubt anyone is going to work this into production code. No one is going to turn off ngzone globally. The main problem is component level control of rerender is going to be more performant than service level control of rerender. Writing acode to batch aync code properly for performance is a friggin chore. rather than this, i would like to see more support for custom ChangeDetectionStrategy or increased options. ChangeDetectionStrategy.OnCustom({rerenderOnAsyncOps: false}) that's step 1 . Reactive Component Library is step 2.

legacy projects? 🤷‍♂️

@@marcialabrahantes3369 you can use react in angular in such case still and step by step replace. React is just a lib.

Yes, it will unsubscribe automatically… once the call will be completed, but it is better to do it onDestroy as in this case it will unsubscribe exactly onDestroy and cancel all pending requests

What's wrong with HOCs? They are awesome for lots of things... form elements for instance

@@LarsRyeJeppesen One prime reason why React made the hooks api is to get rid of the HOC pattern

@@hamzabenkhaldoun ok thanks

HOCs have some limitations, one of theme is multiple class inheritance, in React world for that case composition has comes and HOC’s works as expected, that’s is more suitable for functional paradigm but Angular is on the OOP way and I suppose it is more fashion way to apply props through annotation decorators @connect()

did you import CommonModule?

Yeah, there is no memory leak as mentioned at 1:57. But you might still want to unsubscribe so the subscribe callback doesn't get called.

you HAVE TO, else, you may get tons of memory leaks and strange behavior when your requests take longer than expected (30sec request time)

@@marianbencat6658 I do not see what you mean. Unsubscription is handled in success / error case automatically. Of course calling the unsubscribe method is useful when yout have to cancel an "in progress" HTTP request

@@MAKU011111 read it again and slowly... - yes, unsubscription is handled in success / error case - yes, when request ENDS with success / error - WHEN REQUEST ENDS - so if requests takes 30 sec, you are leaking resources for 30sec. MEMORY LEAK: - not freed resources when not needed anymore - try to subscribe in a component to 30sec (or timeout) lasting request and go BACK and THERE 30times... = you will need 30x more resources + YOU WILL LISTEN 30times except once.

@@marianbencat6658 yeah I get you point. But this example is very constructed.... In general I would not handle the unsubscription of http calls (but thats my personal opinion - but also heard on several occasions from others)