bro in my app in players turn there shows 2nd player name only even in players 1 turn

@@razanshrestha9651 Could you put your project on GitHub so I can take a look at your code?

Hi, once again awesome video, thank you so much! I noticed this issue but I resolved it through adding a boolean value isDraw in gamelogic.java , then changed it to true in the isDraw in the else if(boardfilled == 9) part of the Winnercheck method. Then added I believe it's called a setter method: public boolean isDrawgme(){ return isDraw; } Then changed the if statement in the onDraw method in TicTacToeBoard.java to if (game.isDrawgme()){ return; } else if (winningLine){ paint.setColor(winningLineColor); drawWinningLine(canvas); } Is this just horribly inefficient?

Awesome!!! ;)

Hi, you need to reset wineType to default values

happy to hear you liked the videos! It's always good to know my videos are helping people out

Glad you liked them!

have you finished it ?

@@polsoft6380 Yeah that's everything

glad to hear it!

Yeah that's something I can start working on! Thanks for the video idea and I'm glad you're liking the videos

Yeah, you could draw the winning line behind the player markers or even the game board if you wanted. If you go to the onDraw method in the TicTacToeBoard.java file all you would have to do is change the order that you draw everything. In the method, you'll see that we call the drawWinningLine method after we draw the gameboard and markers. If you place the drawWinningLine method after the drawGameBoard method and before the drawMarkers method (so in the middle of the two) I think you'll get the result you're looking for

What issue are you running into?

I fixed with a simple if statement that says if the playerName equals empty string set it to "Player1" but I wonder if there's a cleaner solution using default values.

Yeah, that was my bad. I've had a few other people mention this to me. I forgot to add a few things to the code while I was recording the video. Glad you figured it out though!

​@@paweswiderski5411 There might be a better solution, but I haven't looked at this project in a while so I'm not 100%. When I make these videos, I'm not too worried about the code being the absolute best. As long as it works and doesn't look like complete garbage I'm happy with it. I think the main goal for these videos is getting people comfortable with the processes of creating something from scratch rather than having the best/most simplified code possible. If you find a better way to do it you can always leave a comment showing what you did or post something in the Discord server. It might help someone out seeing it done in a different way

It's going to be in a few places (not sure which one you're looking for so here's everything). We create the attribute field in the attrs.xml file (along with every other color used by our game board). Then in the XML file where our game board is placed (game_display.xml), we actually set a value to that attribute (red, green, purple, whatever color you want). Finally, in the TicTacToeBoard class (Where we write the code to create the custom view), we extract that value from the color given in the tictactoe XML tag in the form of a TypedArray and store it in a variable I called "diagonalColor" If that doesn't answer your question just let me know!

Thanks! Did you ever get the sudoku board working? I just read your other comment

@@PracticalCoding yeah I get sudoku board, but I have a problem Vertical line note work

@@Instantcrypt Can you put the code you're using to draw the vertical lines in a comment so I can take a look?

@@PracticalCoding sir, it works only the first vertical line second & third line not show....!!

I made this a while ago so I'm not sure how everything was laid out exactly but I would think you'd need to pass the value of the "player" variable in the GameLogic class to GameDisplay when you click the play again button. You could do that with intents (basically what we did when we were collecting the names of each player) then when the GameDisplay Activity loads, you can pull the player value out of the internet and set it in the GameLogic Class. You might need to create getters and setters for that variable though. I can't remember if we made them or not. If you run into any issues, you can always join the Discord server I set up for this channel and talk about it there. We have a pretty big community and everyone always helps out. Here's the link if you wanna join: discord.gg/H2P89STbaS

@@PracticalCoding Thanks for responding, I will try the solution and see if I can make it work. I'm new to Java and really learnt a lot, I'll surely join the group and learn more from other tutorial series you created, thanks.

Yeah, a few other people pointed this out to me when I first uploaded the video. If you take a look at the comment I pinned, it'll explain how to fix the issue

Yeah, I have it posted on my GitHub page. Here's the link if you wanna check it out github.com/Practical-Coding3/TicTacToeApp

That would be cool! I'll have to look into that

Yeah, you should be able to. Instead of using the draw line method try using the drawBitMap method

Yeah, that wouldn't be too difficult to add in. I've walked a few people through the process of adding AI into the app. Once I'm done with finals and I take the MCAT, I can probably make a video on it.

@@PracticalCoding that'd be amazing to look at, your walkthroughs have actually helped me out a lot so I really appreciate it!!

Yeah that's a great idea! Right now I'm on vacation so when I get back I'll work on making that video next

@@PracticalCoding Oh! sorry for disturbing you...my bad. :) Thanks by the way and Merry Christmas!!!

@@realfaw Merry Christmas!! I'll let you know when I post the video. I get back on Monday so it'll be a few days

Sounds Great! I need tut too!!

I like that idea. I'll have to add that one to the list

That would be pretty cool. Not sure about using the pen but I could definitely make a note app. I'll add it to the running list of video ideas

Hey! Do you mean you would like to see a video on how to use the Google assistant in android studio?

@@PracticalCoding Hey, happy new year! No i think to make a own own talk assistent! Do you understand? Thanks for your reaction

​@@franky3728 That would be cool but I know that's something I couldn't do right now. If you wanted to make something like that I would recommend starting machine learning. That's just how you're gonna have to do it. I started reading a book about machine learning a few weeks ago that I would recommend you take a look at it if you're really interested in getting this project started. It's called "Hands-on Machine Learning with Scikit-Learn, Keras & TensorFlow" Here's the link to the book on Amazon if you wanted to pick it up www.amazon.com/Hands-Machine-Learning-Scikit-Learn-TensorFlow/dp/1492032646/ref=sr_1_3?crid=3A4QH4EQDGN7J&dchild=1&keywords=machine+learning+book&qid=1609494064&sprefix=macine+lear%2Caps%2C187&sr=8-3 I've only read a little bit so far but from what I've read it's a great book and it has 5 stars on Amazon. It's all in Python but I'm assuming you know Java or some other language so you shouldn't have too much trouble with it. Hope this helps!

@@PracticalCoding tanks for worth it and I'll have a look! you also want to do something where you can retrieve data from your game / app?

I just checked the program and I'm not getting the same thing happening for me. What could be happening is the winningLine variable is being set to "true" somewhere it shouldn't be. I would have to look through your code to be sure though.

@@PracticalCoding ok! so this is the code from the tictactoeboard.java file pls check if there is a mistake [edit: I also found out that the winning line is set "false" I think there is no problem with the winning line variable pls fix this cuz I have copied the code you can fix it by replying] package com.faw012.tictactoe; import android.annotation.SuppressLint; import android.content.Context; import android.content.res.TypedArray; import android.graphics.Canvas; import android.graphics.Paint; import android.os.Build; import android.util.AttributeSet; import android.view.MotionEvent; import android.view.View; import android.widget.Button; import android.widget.TextView; import androidx.annotation.Nullable; import androidx.annotation.RequiresApi; class TicTacToeBoard extends View { private final int boardColor; private final int XColor; private final int OColor; private final int winningLineColor; private boolean winningLine = false; private final Paint paint = new Paint(); private final GameLogic game; private int cellSize = getWidth() / 3; public TicTacToeBoard(Context context, @Nullable AttributeSet attrs) { super(context, attrs); game = new GameLogic(); TypedArray a = context.getTheme().obtainStyledAttributes(attrs, R.styleable.TicTacToeBoard, 0, 0); try { boardColor = a.getInteger(R.styleable.TicTacToeBoard_boardColor, 0); XColor = a.getInteger(R.styleable.TicTacToeBoard_XColor, 0); OColor = a.getInteger(R.styleable.TicTacToeBoard_OColor, 0); winningLineColor = a.getInteger(R.styleable.TicTacToeBoard_winningLineColor, 0); } finally { a.recycle(); } } @Override protected void onMeasure(int width, int height) { super.onMeasure(width, height); int dimension = Math.min(getMeasuredWidth(), getMeasuredHeight()); cellSize = dimension / 3; setMeasuredDimension(dimension, dimension); } @RequiresApi(api = Build.VERSION_CODES.LOLLIPOP) @Override protected void onDraw(Canvas canvas) { paint.setStyle(Paint.Style.STROKE); paint.setAntiAlias(true); drawGameBoard(canvas); drawMarkers(canvas); if (winningLine){ paint.setColor(winningLineColor); drawWinningLine(canvas); } } @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouchEvent(MotionEvent event) { float x = event.getX(); float y = event.getY(); int action = event.getAction(); if (action == MotionEvent.ACTION_DOWN) { int row = (int) Math.ceil(y / cellSize); int col = (int) Math.ceil(x / cellSize); if (!winningLine) { if (game.updateGameBoard(row, col)) { invalidate(); if (game.winnerCheck()){ winningLine = true; invalidate(); } //updating the players turn if (game.getPlayer() % 2 == 0) { game.setPlayer(game.getPlayer() - 1); } else { game.setPlayer(game.getPlayer() + 1); } } } invalidate(); return true; } return false; } private void drawGameBoard(Canvas canvas) { paint.setColor(boardColor); paint.setStrokeWidth(16); for (int c = 1; c < 3; c++) { canvas.drawLine(cellSize * c, 0, cellSize * c, canvas.getWidth(), paint); } for (int r = 1; r < 3; r++) { canvas.drawLine(0, cellSize * r, canvas.getWidth(), cellSize * r, paint); } } @RequiresApi(api = Build.VERSION_CODES.LOLLIPOP) private void drawMarkers(Canvas canvas) { for (int r = 0; r < 3; r++) { for (int c = 0; c < 3; c++) { if (game.getGameBoard()[r][c] != 0) { if ((game.getGameBoard()[r][c] == 1)) { drawX(canvas, r, c); } else { drawO(canvas, r, c); } } } } } private void drawX(Canvas canvas, int row, int col) { paint.setColor(XColor); canvas.drawLine((float) ((col + 1) * cellSize - cellSize * 0.2), (float) (row * cellSize + cellSize * 0.2), (float) (col * cellSize + cellSize * 0.2), (float) ((row + 1) * cellSize - cellSize * 0.2), paint); canvas.drawLine((float) (col * cellSize + cellSize * 0.2), (float) (row * cellSize + cellSize * 0.2), (float) ((col + 1) * cellSize - cellSize * 0.2), (float) ((row + 1) * cellSize - cellSize * 0.2), paint); } @RequiresApi(api = Build.VERSION_CODES.LOLLIPOP) private void drawO(Canvas canvas, int row, int col) { paint.setColor(OColor); canvas.drawOval((float) (col * cellSize + cellSize * 0.2), (float) (row * cellSize + cellSize * 0.2), (float) ((col * cellSize + cellSize) - cellSize * 0.2), (float) ((row * cellSize + cellSize) - cellSize * 0.2), paint); } private void drawHorizontalLine(Canvas canvas, int row, int col) { canvas.drawLine(col, row*cellSize + (float)cellSize/2, cellSize*3, row*cellSize + (float)cellSize/2, paint); } private void drawVerticalLine(Canvas canvas, int row, int col) { canvas.drawLine(col*cellSize + (float)cellSize/2, row, col*cellSize + (float)cellSize/2, cellSize*3, paint); } private void drawDiagonalLinePos(Canvas canvas) { canvas.drawLine(0, cellSize*3, cellSize*3, 0, paint); } public void drawDiagonalLineNeg(Canvas canvas) { canvas.drawLine(0, 0, cellSize*3, cellSize*3, paint); } private void drawWinningLine(Canvas canvas) { int row = game.getWinType()[0]; int col = game.getWinType()[1]; switch (game.getWinType()[2]) { case 1: drawHorizontalLine(canvas, row, col); break; case 2: drawVerticalLine(canvas, row, col); break; case 3: drawDiagonalLineNeg(canvas); break; case 4: drawDiagonalLinePos(canvas); break; } } public void setUpGame(Button playAgain, Button home, TextView playerDisplay, String[] names) { game.setPlayAgainBTN(playAgain); game.setHomeBTN(home); game.setPlayerTurn(playerDisplay); game.setPlayerNames(names); } public void resetGame() { game.resetGame(); winningLine = false; } }

@@PracticalCoding and..this is the code from the GameLogic.java file pls check if there is a mistake here too package com.faw012.tictactoe; import android.view.View; import android.widget.Button; import android.widget.TextView; class GameLogic { private int[][] gameBoard; private String[] playerNames = {"Player 1", "Player 2"}; //1st element --> row, 2nd element --> col, 3rd element --> line type private int[] winType = {-1, -1, -1}; private Button playAgainBTN; private Button homeBTN; private TextView playerTurn; private int player = 1; GameLogic(){ gameBoard = new int[3][3]; for (int r=0; r

@@PracticalCoding if you need more code from other files pls tell me i will reply the code here

@@realfaw Hey I'm looking through the code right now but I just wanted to make sure that you called the reset game method in the "GameDisplay.java" file when the user clicks the play again button

This was the last video in the series. Were you looking to see something else in the videos?

@@PracticalCoding yes an upgrade soduko solver where it gives a hint and that you can play on your phone? is this an idea?

@@PracticalCoding An upgrade?

@@franky3728 Oh I gotcha. So instead of just the sudoku solver, you'd be able to play an actual game. That's not a bad idea

@@PracticalCoding yes and by the soduko solver dread it gives hints and the solver Which all is already in there and Maybe With ads?

here's the link github.com/Practical-Coding3/TicTacToeApp

@@PracticalCoding Thx

Hey! This might be something I do in the future, but right now I'm working on making introductory videos for app development

@@PracticalCoding pls upload code on github

@@shahacademy4687 I should have all of that linked on my channel page, but here's the link github.com/Practical-Coding3/TicTacToeApp