When You Ask the Intern to Review Your Code

No video

When You Ask the Intern to Review Your Code

Рет қаралды 584,365

Nicholas T.

Күн бұрын

Пікірлер: 361

@HoloTheDrunk 11 ай бұрын

The real intern experience is spending a week working on a PR, sending it in with everything ironed out perfectly, having crafted the best PR of your entire life, then seeing it rot on the task list with a low priority number for months

@weak1ings 11 ай бұрын

And then never getting merged until it is inevitably closed!

@rewrose2838 11 ай бұрын

Bro!! I thought I was the only one. I had fixed a major issue in production, gave the PR and it got merged after two months lol. I had literally zero tasks for those months

@AnibalAlvarez 11 ай бұрын

The best python package of my life was never even reviewed

@augustofotino523 11 ай бұрын

This gave me PTSD

@tilmanrotationalinvariant2257 11 ай бұрын

Months? More like years! I have in all seriousness a couple of PR's from over a year(when I started) open. Lets see if they are gonna be reviewed next year...

@TheAkiller101 11 ай бұрын

switching variable colour to color has made it 20% efficient saving millions of dollars in cloud cost. keep up the great work !

@AryanGNU 11 ай бұрын

Lmao chuckled so hard 😂😂😂

@triplezgames3882 11 ай бұрын

Actually, "colour" is 20% less efficient than "color", but "color" is 16,67% more effective than "colour"

@magicmulder 11 ай бұрын

You can actually put 10% of the code in the filename. Huge space saver.

@hnazmul 9 ай бұрын

😂😂😂😂

@michaelburton9420 11 ай бұрын

Intern tension: "I'm new and am expected to know these things. I can't ask or they will think I don't have a clue what I'm doing. But I also don't feel like I know what I'm doing." Senior tension: "This kid must be brilliant because they haven't asked questions. They must know the latest/greatest practices so I can't question that. I don't understand this and I'm expected to teach them..." Both: LGTM

@AnibalAlvarez 11 ай бұрын

There are some words in that hudge fact

@KristianTheDesigner 11 ай бұрын

As a frontend dev who started just 6 months ago i need to say that this comment made me calm 😁 Thanks

@xgcwrought3346 10 ай бұрын

Omg is this what I get to look forward to?

@liloruf2838 9 ай бұрын

True! The best is when seniors just explain everything without me having to ask😂😂😭

@sypwer 2 ай бұрын

If that's honestly the senior tension I might not ask questions ever

@max3446 10 ай бұрын

Actually worked with an intern who manually changed his job title on the internal portal to 'senior software engineer intern' as it was his 4th internship at the company - made me giggle.

@matteosposato9448 10 ай бұрын

Fun and brilliant! But maybe also a way to say that rather than having a fourth internship one should be hired or at least get a consultancy? Don't know about the specific situation so maybe you'll tell more, but fourth internship (and at the same company!) sounds out of this world to me

@hunter-tm2kl 6 ай бұрын

@@matteosposato9448 i had a friend who did 4 separate terms at a big fintech company and he worked on a different team each time

@HeatFort 6 ай бұрын

@@matteosposato9448probably still in school so they were waiting to hire him

@marcialabrahantes3369 5 ай бұрын

@@matteosposato9448I've seen that for students that are going into Master's program

@nootanwait2358 2 ай бұрын

@@matteosposato9448I did 3 paid internships for the same company - during the student vacations each year in university. So if they're still full time studying then it's not necessarily exploitative

@AwesomeDwarves 11 ай бұрын

That feeling of "He wants me to review *his* code?" is truly universal for software devs

@peterlyon185 11 ай бұрын

Intern manager had me dying 💀

@jondoty 11 ай бұрын

The real intern experience is spending a week working on a PR, sending it out for review, then finding out the requirements were all wrong because the senior engineer that gave you direction was not on the same page as the other senior engineers.

@coherentpanda7115 11 ай бұрын

That's an every software developer experience, including for seniors.

@NevosLP 9 ай бұрын

Has happened so many times to me...

@marc-andrefortin 8 ай бұрын

Classic

@maryammoghaddas768 2 ай бұрын

Unfortunately I have been the one creating this scenario for a new hire. It sucks on the senior/mid side too. After several cases of this, I tried to iron out the details before giving the task and that helped tremendously.

@JTBanks 11 ай бұрын

This has no business being this good!! Insane how much work put into this, truly appreciate you.

@nicholast 11 ай бұрын

glad you enjoyed it

@adityasuryawanshi3263 11 ай бұрын

@@nicholastwhat is the name of that utility at the start of the video where you are managing all the tasks, looks cool?

@marjo9952 11 ай бұрын

@@adityasuryawanshi3263 "Trello" I'm assuming

@cody_codes_youtube 11 ай бұрын

Ohhhh my god. Sooo many Easter eggs in this video. This had to take so much time and also worth every second!

@kevinbrandon1856 3 ай бұрын

Please don’t use the name of God in vain!

@ogmoiz 11 ай бұрын

after starting my first internship i can finally relate to all the intern memes and confirm they are 100% accurate

@ConfusedWatermelon 11 ай бұрын

congrats on internship!

@antekliyue9874 10 ай бұрын

so are you intern manager yet?

@keyeslord 2 ай бұрын

@@antekliyue9874no he’s senior intern manager

@otisroot 11 ай бұрын

Not only did I review my mentor’s PR, I REJECTED it

@bluesteel1 10 ай бұрын

I will definetely add the following point to my resume "Increased corporate profits by 27% by enhancing user experience by shifting critical ui component to utilize warm shades" paraphrase: I made a button red

@angelg3642 5 ай бұрын

Naaah you legit gotta do that 😂😂😂😂😂😂. The smarter it sounds the more impressed the HR's are. It's legit comedy sometimes

@lockaltube 2 ай бұрын

Sounds more like "improved performance", because red is faster!

@Mempler 14 күн бұрын

@@angelg3642the less people understand, the more they think that you know your stuff

@cokikillide5855 10 ай бұрын

I'm a junior dev. My team recently had a new senior dev join. Senior dev clones a repo and starts making some changes and asks me, why doesn't their code work. I tell them to please push their code to another branch so I can review. One week later, sends me a zip file containing the whole project repo (doesn't know how to use Git Hub). First thing I see are a bunch of nested loops, 150 lines of if-else statements, a bunch of poorly named variables, and no comments. WTF. I'm dead.

@Haise-san 10 ай бұрын

That doesn't sound like a "senior" dev, but what do we juniors know lmao, maybe he was into something

@jakobullmann7586 10 ай бұрын

Been there, that’s real life. Maybe not at FAANG, but in smaller companies or teams this can definitely happen. Promotions based on seniority, not skill level… My advice: Stay away from those companies/teams. Work with skilled people and for companies that value skill.

@siliconhawk9293 7 ай бұрын

@@Haise-sanhe probably was on to something he didn't become a senior engineer just like that. right guys ?

@MrCmon113 6 ай бұрын

At least he zipped it. He could have sent a rider into your town to read the code out loud in the market square.

@angelg3642 5 ай бұрын

HOW HOW HOW HOW HOW DID THAT HAPPEN ????? My last interview I straight up outperformed 90% of the candidates and that was still not good enough. WHAT THE FUCK ????

@MrAustonpowers 11 ай бұрын

I recently got put on a new project at work and this is way too relatable / anxiety inducing! Well done, sir!

@minnie-piano3969 11 ай бұрын

0:43 you forgot the holy title of INTERN CEO

@nicholast 11 ай бұрын

chief intern officer

@d_sanu 11 ай бұрын

That's a CIO... 😂 not CEO

@armtdawg99 6 ай бұрын

Chief Executive Intern

@Wulfy013 11 ай бұрын

I am SO happy to have you posting again! Damn near pissed myself laughing LGTM!

@nicholast 11 ай бұрын

Glad you enjoyed it :)

@zacanger 11 ай бұрын

If CI passes, it's totally fine. I just started at a new company and haven't really learned some of the systems yet, so I just depend on compiler errors and tests to tell me if I'm breaking things. Just like an intern.

@andyschee942 11 ай бұрын

CI is the bare minimum. Most part of code review isn't even about things that broke. Also really depends on the quality of CI how reliable it is for detecting broken things.

@broadestsmiler 10 ай бұрын

@@andyschee942 Big vouch for the Scheester. Making sure that your code follows the proper standards (well documented with comments, proper usage of variables and functions, ensuring everything is clean etc.) is super integral to having great code. Bad code breaks, good code just works, great code works and can be understood and fixed easily in the future.

@GuagoFruit 11 ай бұрын

I wonder what the world of "structured" software engineering is like. I'm working in research and optimising/adapting ML algorithms but there's no code review, only results review, and no one else knows my code but me. I feel like I'm losing my mind with the freedom I'm allowed because I'll have 5 things I want to do but can only have time to do 1.

@traveller23e 11 ай бұрын

I work on legacy mainly, and it's a lot of "do exactly what was requested, and _only_ what was requested". Just today I got back from lunch to find several messages about how a PR of mine last week broke the release branch for everyone on another (parallel) team. This issue could be solved with a basic try-catch, but to be honest having looked through it further I don't know that we want to even make the change I was asked to make (and already implemented, albeit with a bug) due to subtle issues that are direct results of this plan.

@antoruby 11 ай бұрын

You need someone to help you with prioritizing the tasks, taking stakeholder impact into account

@rewrose2838 11 ай бұрын

@@traveller23eThis was nice to read. Sometimes I'm scared that I'm the only idiot that makes these kinda breaking changes.

@nam9221 11 ай бұрын

Im working as an intern in an ML research project, mostly just reporting results from different papers. I feel like ive hit a ceiling mathematically and my major isnt focused on ML its actually cybersecurity. How do you suggest I get better?

@traveller23e 11 ай бұрын

@@rewrose2838 Nah mate, people have broken release three times since I wrote that a week ago. As long as someone catches it before there's a real problem, you're fine.

@twilightgeneral777 11 ай бұрын

Congrats on the promotion to Double Super Intern: First Class!

@Sh4ndes 11 ай бұрын

I just started my web development internship, and this is relatable af

@Claude_Developer 27 күн бұрын

Great work! love your content. Keep it up!

@joehaynes7092 10 ай бұрын

Good ol intern days they had me twiddle from thumbs for 4 weeks then gave me some random code story development with one sentence in rally describing what to do and then being busy for the whole week only to get the jr offshore developer to yell at me for what I was doing 😅. The managers would then not find any other work until it was two weeks until I was supposed to leave and act like they loved me.☠️

@sibusisomfana6388 11 ай бұрын

😂😂😂😂😂"Talks in Intern" I can so relate

@GeneralKenobi69420 11 ай бұрын

As a 28 year old whos never had a job I can confirm this is an accurate depiction of being an intern at a tech startup

@SkyArmysGeneral 11 ай бұрын

Bum

@surfingbilly9654 11 ай бұрын

Gigachad

@MrCmon113 6 ай бұрын

Keep it like that. Work sucks.

@DrDiabolical000 3 ай бұрын

@@SkyArmysGenerallife's tough and unpredictable. Be humble.

@keyeslord 2 ай бұрын

Being privileged enough to never work is crazy

@HM-ch 11 ай бұрын

I showed your video to the Senior Intern on our team and he confirmed that this is how it goes.

@keyeslord 2 ай бұрын

You guys have a senior intern??

@delevoxdg 11 ай бұрын

Great content, was watching your vids while prepping for the interviews and they were great at boosting my morale. Now after getting a return offer this week, this video seems like a cherry on top.

@NathanLuMax 11 ай бұрын

Bro I relate to this so hard 😂

@sandupaegodage8163 11 ай бұрын

"No description provided" smells like Sr.Engineer

@robottrainer 10 ай бұрын

+ Points on the theta numerology function, that was intense.

@striderstache99 11 ай бұрын

Love that red "Purchase" button. Such a subtle detail describing a dark pattern. But hey, if it makes money....😂

@souravh7637 2 ай бұрын

"Speaking Intern " --- All can relate ig🤣

@limeisrichard 11 ай бұрын

i love when speech is coming through my back left ear

@davidmwakonya3324 11 ай бұрын

The relatability in this😂

@nojustno2526 11 ай бұрын

i literally just had to review an MR on a project i worked on in the spring that a swe outside my team was trying to contribute to. It was terrifying

@dnserror89 Ай бұрын

3.5 YOE as a front-end dev and finally feel comfortable reviewing seniors' code and actually providing meaningful feedback and/or improvements lol.

@johndevnoza4223 18 күн бұрын

"Senior intern" i lost it! :Ddddd

@topsykretts2264 7 ай бұрын

Always better to ask questions. Just make sure it’s the right time and setting. Know how to read the room.

@Ecann72 11 ай бұрын

IVE MISSED THESE VIDEOS

@nang88 11 ай бұрын

this is me as a full-timer

@nicholast 11 ай бұрын

I’m tryna get promoted to full timer

@mctv2-randomness355 11 ай бұрын

YOOO my favorite youtuber uploaded, day made😍

@brnzhng 11 ай бұрын

LFFGG

@ilearncode7365 11 ай бұрын

The only difference between this and “seniors” reviewing is that they nitpick even dumber things and constantly ask you what something does

@nooblal 11 ай бұрын

Knowing when and how to ask questions is knowledge too

@coherentpanda7115 11 ай бұрын

I don't mind nitpicking, it's all in how they conduct it. If they ask the right questions, like "Would it be better if we do XYZ? or "Are we able to do such and such on this line?" than they give you the opportunity to rebuttal or agree without them feeling like an ass, and you feeling like an idiot. Most good companies train on how to properly review PR's, and its a Senior priority to keep comments professional.

@simi6996 11 ай бұрын

love it man! Keep dropping.

@DjSquatter 5 ай бұрын

Shit, I had tears rolling on my cheeks from laughing. Nice one !

@istvanbarta 10 ай бұрын

They should do this in a meeting, discussing it maybe line by line, the intern could learn a lot, and the senior also have a recheck his own code.

@bananesalee7086 11 ай бұрын

Got a senior in my team whom's process is probably similar because he only nitpicks on stuff while there's huge blatant bugs in plain sight

@coherentpanda7115 11 ай бұрын

It's that and also everyone has a Senior who just rubberstamps everything for their best friend that is filled with breaking changes, yet everytime they review your PR they go through it character by character nitpicking every detail with comments.

@MrDavidRaw 11 ай бұрын

ella ellaaa ehhh ehhhh shoutout rihanna ! good work on this one bro

@natashajchen 11 ай бұрын

video editing attention to detail goes craaazy !!

@darkin1484 10 ай бұрын

Engineering Manager: guys who deleted 95% of the code?

@tiimmng 11 ай бұрын

fwiw I wouldn't even look at a large pr like that 😂 usually they won't get looked at for a vvvv long time

@NotYoel 11 ай бұрын

loved the video. keep dropping more 👍

@nicholast 11 ай бұрын

MORE SKITS COMING

@alexeyman7301 10 ай бұрын

Assistant TO the intern Manager?!

@kwoknation 11 ай бұрын

I DONT CODE 🔥🔥🔥 BUT THIS IS FIRE 🔥🔥🔥

@nicholast 11 ай бұрын

ITS OK IM AN INTERN I DONT CODE EITHER

@WelcomeBub 11 ай бұрын

LGTM, great work! If this was real I would cry at my desk.

@gordonduan2415 11 ай бұрын

I have never related to a video more in my life 😭

@Vcksn 10 ай бұрын

The emojis part had me dying😂😂😂

@thereasonableprogrammer4921 6 ай бұрын

The “No description provided” on the pr hit deep 😂

@TheGrimravager 11 ай бұрын

This is amazing, keep pausing the screen for the fantastic jokes all around >guys why is prod down it's literally 1 am

@huynguyenq7333 4 ай бұрын

"speak in intern" part make me 😂

@dapyr 11 ай бұрын

Weather magician

@jasonpittman7853 28 күн бұрын

I’m an intern and my boss just told me to have the other intern run the PR. Godspeed codebase two interns have invaded.

@vladvlad2289 7 ай бұрын

1:15 If I ever see that in a PR, I'm going to church.

@dragonarc_gaming 10 ай бұрын

When the senior is drunk and the intern is delusional. Good context I should say XD

@bilgecimen4243 11 ай бұрын

This made my day, great content!

@AeonFM 6 ай бұрын

My left ear really enjoyed this

@hjkfyt3305 5 ай бұрын

Same thing happened to me as a intern. You know what my senior co-worker did? Without any word he stood up from his chair, walked next to me, took my laptop and reviewed it in 2 seconds. Yeah, at that time it was my first experience with git, so I didn’t even remembered what happened 😂 Of course he was teaching me more later

@GainsGoblin 11 ай бұрын

"senior intern" holy shit im dying

@harshilshah980 11 ай бұрын

‘speaking in intern’ had me dying considering I’m still learning the language

@faresk3168 11 ай бұрын

Welcome back man!!

@jojox1904 10 ай бұрын

I accidentally took down one of our clients websites today for like an hour because I merged into master instead of testing 😭

@StinkyCatFarts 3 ай бұрын

Send it back to the senior and tell him to code like a senior

@Mohit-wb5cv Ай бұрын

weather magician

@abdiraqiibmohummed9781 11 ай бұрын

hes baaaaaaaack !!!

@mlevvy96 5 ай бұрын

"yeaaaahhh should be fine" half of the time ends in disaster XD of course if it's merged without in-depth code review

@prasenjitsutradhar3368 11 ай бұрын

Intern => senior intern => intern manager....wow! great progress in career.

@nullObject_ 2 ай бұрын

00:24 "He wants me to review his code?" Every SE has experienced this feeling once

@easternplatypus 10 ай бұрын

my left ear liked this video 👍

@tarn84 11 ай бұрын

ayeee he is back with the quality content

@BruceWayne-iw7wg 11 ай бұрын

This video had me in [speaking in intern] 😂. Idk why but it felt hilarious 😂.

@salal_guitar5583 2 ай бұрын

Lmao @ all the CI checks passing 😂

@xellestar 11 ай бұрын

"should be fine" now that's what i call high test confidence

@Gamer_with_knowledge 11 ай бұрын

Was waiting for your videos :)

@andrewdddo 11 ай бұрын

waited so long for a new video lesgoooo!

@QuransGems-zd1jd Ай бұрын

2:54 was the best!

@doorey2 11 ай бұрын

"Migrate literally everything to typescript."

@SuperElephant 11 ай бұрын

My left ear enjoyed this video 12.5% more than the right.

@hootels1770 11 ай бұрын

From what I’ve gathered from coding videos it seems no one really knows what they’re doing and if that’s true that’s funny as hell

@rkpinata373 11 ай бұрын

its an exaggeration. applications can get big with a lot of moving parts so sometimes even experience seniors are seeing a part of the code base for the first time. But for them they eventually figure it out. I was assigned a bug ticket and had to get a senior help and we debug together. He was also super confused but eventually when i pointed out the root of the problem ( i had more time to read that part of the code) , he saw it was his faulty code written 3 weeks ago😂

@DDracee 9 ай бұрын

@@rkpinata373 depends where you work, i can point you to the team fortress 2 code, sometimes it's just a bunch people bashing their head against the wall until something ends up working by happenstance

@johnallentech 11 ай бұрын

This video was my reason to subscribe

@elitejv 9 ай бұрын

It's kind of interesting to see a perspective from a modern day intern. I guess I'm considered a senior by now, 12 years at my company. It's painful to see what is changed too, though. I recognize parts of this behaviour in my junior team members, and most eerily: myself. Just skimming through PR's and asking some basic BS to make it look like you've actually seen the stuff. Just watching pipelines and testsuites to confirm checkmarks. AI might be the best and worst things that could have happened to us. We going obsolete boys.