How to Review a Pull Request Like a Senior Developer

  Рет қаралды 14,192

Matt Stauffer

Matt Stauffer

Күн бұрын

Learn how to review a GitHub pull request--where do you look first, when do you wait for their feedback and when do you proceed on your own, and more!
00:00 - Introduction
00:38 - Read the title and description (and issues)
03:11 - Look at the code
04:31 - Look at the commit history
05:08 - Reproduce locally
08:00 - Sending feedback
10:58 - Merge -- but which type?
12:56 - Co-authoring a pull request
13:53 - Conclusion

Пікірлер: 10
@user-nz4vi9pf3k
@user-nz4vi9pf3k 11 ай бұрын
Well done! thank you for this well rounded explainer. I would appreciate more videos on github like when to use Merge and when to use Rebase and similar subjects from the magical world of senior developers 😅
@patrykseweryn618
@patrykseweryn618 3 ай бұрын
Really cool video! Thanks a lot for your content, helped me a lot! :)
@fwefhwe4232
@fwefhwe4232 6 ай бұрын
excellent video. exactly what I was looking for.
@MattStauffer
@MattStauffer 6 ай бұрын
Glad it was helpful!
@nabeelyousafpasha
@nabeelyousafpasha Жыл бұрын
Really helpful. Respect from Pakistan
@rizwansworld
@rizwansworld 24 күн бұрын
Thanks man. Helpful.
@NiteenGaikwad1593
@NiteenGaikwad1593 Жыл бұрын
do you use rebase and merge option? what is benifit of that
@ponderatulify
@ponderatulify Жыл бұрын
templates and conventions
@tenebrae1191
@tenebrae1191 Ай бұрын
👍
@rajeshdhanda5913
@rajeshdhanda5913 20 күн бұрын
so basically senior developer apply more common sense.::))
What is a Pull Request, and How Do I Write Great Pull Requests?
18:13
Matt Stauffer
Рет қаралды 2,8 М.
How to Do Code Reviews Like a Human
22:49
PyGotham 2018
Рет қаралды 37 М.
When someone reclines their seat ✈️
00:21
Adam W
Рет қаралды 27 МЛН
1 класс vs 11 класс  (игрушка)
00:30
БЕРТ
Рет қаралды 3,5 МЛН
How Senior Programmers ACTUALLY Write Code
13:37
Thriving Technologist
Рет қаралды 1,3 МЛН
How to make a pull request on an open source project
16:57
Web Dev Cody
Рет қаралды 67 М.
Never install locally
5:45
Coderized
Рет қаралды 1,6 МЛН
How to Review a Pull Request on GitHub
8:23
Dev Leonardo
Рет қаралды 600
What is a pull request?
8:13
Codecademy
Рет қаралды 137 М.
So You Think You Know Git - FOSDEM 2024
47:00
GitButler
Рет қаралды 987 М.
Junior Developer Sent Me A PR For Review
17:26
Amigoscode
Рет қаралды 165 М.
Git Pull Requests explained - Computer Stuff They Didn't Teach You #5
21:10
i love you subscriber ♥️ #iphone #iphonefold #shortvideo
0:14
Si pamerR
Рет қаралды 3,1 МЛН