What is a pull request?

Рет қаралды 136,782

Күн бұрын

Modern software is never truly finished. Professional developers routinely make changes to their company’s codebase by opening up pull requests. In this video, Pat DePuydt helps us understand why pull requests are so important in a collaborative environment.
Learn Code Foundations with Codecademy: j.mp/2RuDHqM
- - - - -
Join the millions learning to code with Codecademy.
Learn to code: j.mp/3emkQqL
Check out our full course catalog: j.mp/3hbTAgi

Пікірлер: 85

@skyhigh9474 2 жыл бұрын

Shouldn't it be called Push request, because you are requesting to push your changes. Who the hell comes with these names, just to confuse us. If anyone can enlighten me, it helps me a lot.

@user-qb1bv1xf1g 3 ай бұрын

i think they wanted to say that you requesting the repository owner to pull your changes in master branch

@RussianInstructions 2 ай бұрын

Imma pull your code from you and push it to GitHub

@jeanlambert3875 4 жыл бұрын

great tutorial - as a UAT tester on a big IT project I was really wondering what a Pull Request was - now I understand it 100% - without being an IT professional

@wishlish Жыл бұрын

This is fantastic. I'm a product owner, and while I had a vague idea as to what a pull request is, this helped clarify it, and also helped me understand what my next questions will be.

@chandra9491 4 жыл бұрын

it would have been great if you gave some example!

@ParthPatel-jn6io 2 жыл бұрын

Yep good point. Some hands on example related to real world scenario would be helpful

@abc-by1kb 3 жыл бұрын

To save you some time, useful stuff start from here: 3:35.

@philiswashange676 Жыл бұрын

To save you some more time, if you play the video at 1.75x speed it just sounds like hes talking normally.

@EL7NTH 11 ай бұрын

Now I'm confused. I thought the `git pull` is to pull the latest code version to make sure you are working on an updated code from the source with everybody else's changes. And `git push` is when you submit your contributions and get merged with the main branch.

@MohitSharma-xy7xc 6 ай бұрын

git pull is basically a combination of git fetch and git merge, git fetch helps us fetch CHANGES from a remote repository to your local repository. It receives any new branches or changes in the existing branches from that remote repository. Merge basically is when you feel that the branch you are working on is good enough to merge into the master or main branch. $ git pull - fetches CHANGES from a remote repositry and merges these changes into our local machine's master branch $ git push is a command that directly updates a remote repository with your local changes without asking for any permissions Pull request is a higher level concept where you fork (copy) a repository, make a new branch, make changes in it and submit a pull request, where other people will review your work and decide if it is good enough to merge in the source code.

@shapho4056 3 жыл бұрын

Does a pull request include a security review or is more based on functionality / efficiency of the code?

@ionutboghean6883 3 жыл бұрын

Thank you, this helped me understand the concept

@zeester4964 2 жыл бұрын

Exactly the explanation i was looking for, many thanks.

@bryans2790 2 жыл бұрын

Why not just call it Merge Request.. So much more intuitive name.. Pull is confusing depending on which side of the branch you are on.. You are actually pushing your change into the master branch

@Kaindingo 3 жыл бұрын

Crystal clear! THANK YOU!

@tinongnjong1305 Жыл бұрын

OMG your in DC, 3 years ago I would never have imagined I’ll be taking the Codecademy Front-End developer roadmap

@kyledrewes6552 Жыл бұрын

This was very helpful, thank you Pat.

@leninfernandez9279 3 жыл бұрын

GREAT and pretty visually well made explanation

@jonathanhirschbaum6754 3 жыл бұрын

Start at 3:44

@alisherzhumagaliev8798 4 жыл бұрын

Thanks, everything is clear !

@rodlu811 Жыл бұрын

Cool, very well explained and not boring.

@benjordan9347 3 жыл бұрын

Great video! I'm curious, once a pull request is checked out and a merge has been made, is there a way to view previous iterations of the code? I suppose that's why they call it version control, right?

@antilogism 3 жыл бұрын

A merge is a "commit", just like any other commit, except it has multiple parent commits. Since every commit knows its parent or parents you can go back as far as you want. To access the code, you checkout the parent commit you are interested in.

@sadeghmirzaee8258 2 жыл бұрын

That was a good explanation. BUT one problem that I saw was that the volume of the voice was too low. My laptop voice volume is 80 and the KZfaq voice volume set to 90, and still, it's not complete enough for me (I'm not using a headphone and my laptop speakers are ok.) Pls, consider this in other future videos.

@happystoat99 3 жыл бұрын

Clearest and most complete explanations I've seen and nice for visual learners, thanks :)

@RJBoyd-ec6kl 3 ай бұрын

This was so helpful, thank you!

@ARROBACOMPUTERS 2 жыл бұрын

Great explanation! Thanks

@ranjanv4502 3 ай бұрын

Thank you Pat that was a wonderful summary

@chinyeluamobi5725 Жыл бұрын

This video answered alot of my questions

@davidbangsdemocracy5455 2 жыл бұрын

This doesn't answer my confusion. git pull is not a command you do when you want to contribute your changes. git pull just merges other people's changes into my version. Since git pull does NOT contribute my code, how can a "pull request" be the process of contrubuting code. Would not that be a push request?

@toddgilbey3979 Ай бұрын

Excellent explanation. You did briefly touch on this but when going production & cloning the repo to a production server, will this always been the main branch that is cloned or do you have to specify which branch you want cloned? 👍

@DanielHardej Жыл бұрын

Awesome video! Thanks!

@faterosario7872 3 жыл бұрын

Working on group project and I need updates from master branch, What should I do if I want to get updates from master into my branch?

@praseejkumar4365 Жыл бұрын

It is very nice Pat, Thank you...

@vd3412 2 жыл бұрын

nice explanation! thanks

@bagzhansadvakassov1093 2 жыл бұрын

Great explanation.

@tomfredericks8834 5 ай бұрын

Excellent. Thank you.

@asmraage Жыл бұрын

wow!!! this cleared out my frustration about git and pull request. It would be even more efficient if you would and example how it happens

@maximechamis1986 2 жыл бұрын

Thank, very good and clear

@aishwaryam1062 5 ай бұрын

Thanks for your knowledge sharing.can you make a video on how to do pull request with demo?

@primavera919 Жыл бұрын

The name is very confusing, why isn't called a push request since you will be informing others that you have added new code to the remote server? I mean a pull is done when you copy the code to your workspace

@oleggorenkov Жыл бұрын

Why PULL, not PUSH or merge? I'm pushing my code into the main branch, or merging my branch into the main branch. Why is there no push request or merge request?

@tayongsama2499 Жыл бұрын

Excellent video

@MirzokhidMukhsidov Жыл бұрын

It is alright. Worthy to watch.

@mathewkargarzadeh3158 4 жыл бұрын

Thank you !!. now I understand pull request.

@garydunken7934 Жыл бұрын

Do we create Pull Request to push the modified code to master branch? If so, shouldn't it be called a Push Request?

@sharmajicertified 9 ай бұрын

No, what you typically do is you push your changes to a different branch via a push. Then the 'Pull' request is the mechanism by which your branch( and your changes) are pulled into the master.

@panda192012 2 жыл бұрын

Thank you Sir

@BecomeAWebDev 3 жыл бұрын

you didn't show HOW

@bebekbiswas8786 2 жыл бұрын

Thanks!

@brahmcdude685 3 жыл бұрын

no example???

@moonquartzs 3 жыл бұрын

POV: "I have no idea what I'm doing."

@Aanandlahar Жыл бұрын

Can we rename *Pull Requests* to *Push Requests* please?

@Aanandlahar Жыл бұрын

No. Calling it a *Push Request* would be wrong since you request somebody to *pull* your changes into their repository. The technical process really is that the other person performs a git fetch + git merge (which is also known as git pull).

@bardhrushiti4512 3 жыл бұрын

I loved your video! Saved my day. I find the name 'Pull Request' misleading though! You are pulling a request, implies getting a permission or something similar. Agree with the comments down below. 'Merge Request' would be a much better name.

@donovantheprogrammer2989 4 жыл бұрын

So shouldn't it be a "Push Request" or "Merge Request"?

@undefinedchannel9916 3 жыл бұрын

Yup

@ammarhararah3717 3 жыл бұрын

Nope, not quite You request from someone to pull your changes to their branch/repo, hence pull request.

@Itachi.Uchiha.Offical 3 жыл бұрын

Merge Request would make sense and is actually used by some Git vendors, but Push Request is wrong since you request somebody to pull your changes into their repository.

@donovantheprogrammer2989 3 жыл бұрын

@@Itachi.Uchiha.Offical I interpret it more as asking access so you can "push" your stuff into someoneelse's repo

@Itachi.Uchiha.Offical 3 жыл бұрын

@@donovantheprogrammer2989 I understand that, however, the technical process really is that the other person performs a git fetch + git merge (which is also known as git pull).

@nizzinesworkshop2636 2 жыл бұрын

yeah thanks

@nandagopal3814 3 жыл бұрын

the naming is so confusing, "Pull Request"

@sanderkvenild8947 3 жыл бұрын

You are requesting the owner to pull your changes.

@nikhilb3880 3 жыл бұрын

If people click on learning 'pull request' they already know what git is, Why do we have to go through that again

@teddyiliasi8163 3 жыл бұрын

People can hear about it without knowing what git is so he might as well give a quick summary

@CristianTomoiu 3 жыл бұрын

Silvia da approve!

@ssynth4200 3 жыл бұрын

Nu te mai plange ca am dat. Sau vrei iara un urgent message?

@CristianTomoiu 3 жыл бұрын

@@ssynth4200 Mulțumesc mai baiete

@ssynth4200 3 жыл бұрын

@@CristianTomoiu poate vrei dislike cristeee

@AutisticThinker 3 жыл бұрын

NO EXAMPLE!

@yuzeli2303 Жыл бұрын

I think the name "pull request" is so misleading. You are not "pulling", but "pushing" your own branch to the main

@voltexripper8367 2 жыл бұрын

have anyone told u you look like Mr Robot?

@randawg8712 3 жыл бұрын

I have a Poll request... Like of you understand pull requests now?

@felicytatomaszewska2934 7 ай бұрын

All talk... no practical demonstration.

@simmzzzz 6 ай бұрын

This seems like a bad explanation. Confusing branching with what should be forking...

@R1chbloke8 4 жыл бұрын

Love the video Pat, keep up the awesome work!

@iamkakarotsaiyan3918 4 жыл бұрын

thank you!

@Series81 5 жыл бұрын

I think what you describe is a "MERGE REQUEST" (e.g. integrating code changes in the master branch by merging), not something an other developer is pulling. That's why I find the term "pull request" where confusing.

@UniversityAE 5 жыл бұрын

Hey Sebastian! Thanks for taking the time to comment. I think you're right in that a Pull Request does not inherently involve merging but I've never seen a pull request that wasn't intended to be merged in. It's true Pull Requests can be rescinded! But for the most part, Pull Requests are assumed to be merged if they pass review.