Let's Review Your Backend Code | SHALL WE???
Рет қаралды 300,592
2 жыл бұрынIn this video I code review code sent by the Amigoscode community.
#amigoscode #programming #codereviews
Don't Forget to
===========================================
💯 Subscribe to Amigoscode - bit.ly/2HpF5V8
💯 Courses Available for free here - amigoscode.com/courses
💯 Join Private Facebook Group and Discord - amigoscode.com/p/join-community
⭐ Table Of Contents ⭐
===========================================
🙊 Here are the goods for all my videos video 🙊
► Recommended Books
===========================================
- Clean Code - amzn.to/2UGDPlX
- HTTP: The Definitive Guide - amzn.to/2JDVi8s
- Clean Architecture - amzn.to/2xOBNXW
► Computer and Monitor
===========================================
- New Apple MacBook Pro - amzn.to/3464Mmn
- Dell 27 INCH Ultrasharp U2719D Monitor - amzn.to/2xM3nW1
- Double Arm Stand Desk Mount - amzn.to/3aYKKfs
- USB C Hub Multiport Adapter - amzn.to/2Jz7NlL
► Camera Gear
=============================================
- Sony ILCE7M3B Full Frame Mirrorless Camera - amzn.to/346QIJn
- Sigma 16 mm F1.4 DC DN - amzn.to/2wbic3Q
- Sigma 33B965 30 mm F1.4 DC DC - amzn.to/39G37Fd
► IDE & Tools I use for coding 💻 🎒
===========================================
- ITerm
- VsCode
- GoLand
- IntelliJ Ultimate
- Sublime
P.S
===========================================
💯 Don't forget to subscribe | bit.ly/2HpF5V8
💯 Join Private Facebook Group and Discord - amigoscode.com/p/join-community
💯 Follow me on Instagram | bit.ly/2TSkA9w
❤️ Thanks for watching
@1309CV 2 жыл бұрын
This style of content is actually really great. You should definitely do more of this. It's incredibly educational.
@infinteuniverse 2 жыл бұрын
when you're on the job. Your team is expected to give you regular code reviews every time you want to merge changes.
@dwikikurniawan9878 2 жыл бұрын
yes, another video like this, please! 😉
@KawoskiKoh Жыл бұрын
agree especially when you write code similar to these you can see where you improve
@Kotik112 Жыл бұрын
Agreed. I'm looking for my first job as a spring boot developer so these sort of code reviews are "gold".
@phil86_ Жыл бұрын
Absolutely agree. Getting code reviews from Senior devs is crucial and it’s not so obvious unfortunately. This is gold actually.
@pmoieni 2 жыл бұрын
If anyone asked me what's the difference between junior and senior developer I will show them this video
@dc4539 2 жыл бұрын
"Add some tests, it's not difficult", as a support engineer I wish it was more difficult. So many engineers write crap tests that validates their work. It's like awarding yourself a medal
@lion816 2 жыл бұрын
i feel this. test driven development is something everybody should look into imo. i learned it once and will never write code without it. improves quality of tests and production code
@matthewchunk3689 2 жыл бұрын
@@lion816 Just learning how to write fuzz tests. Are there any good resources?
@lion816 2 жыл бұрын
@@matthewchunk3689 we dont really use fuzz testing at work atm, im not so familiar with it sorry :(
@ProxyDE 2 жыл бұрын
hey, i did a great job and my tests prove it. i deserved that medal
@heliophobicdude 2 жыл бұрын
@D C what do support engineers do? Thanks!
@N7Tonik 2 жыл бұрын
cool video idea! but it would be much more helpful if you would explain shortly why you would do things different (and not just what). So a few questions came up for me: 1. why to use "BigDecimal" instead of "Double" for prices 2. why you think that "implements Serializable" can be removed for the dto class 3. which response code is returned if we throw an exception in a controller, 500? 4. why to additionally add the "@Query" annotation to the method declarations of the repository interface, instead of relying on the method name
@RaviYasas 2 жыл бұрын
I have the same question "why do you think that "implements Serializable" can be removed for the dto class"?
@stevenr3537 2 жыл бұрын
I'd actually suggest using the jpa function is better than query, unless you actually have something custom to do. Computer is best at generating these basic queries. The big thing people forget is to ensure their queries hit indexes they have on their table.
@codebitcookie8053 2 жыл бұрын
Computers can sometimes miscalculate floats with rounding errors. See the video about Floats from Computerphile. Since Double is just a bigger float. You should rather use Integers for dollars and cents so 1 dollar = 100 cents, 1.25 dollar = 125, etc.
@stevenr3537 2 жыл бұрын
You should use Big decimal for money amounts, more precision again then Integer
@climatechangedoesntbargain9140 2 жыл бұрын
@@codebitcookie8053 what do you do with 0.9 cents? -> decimals
@amigoscode 2 жыл бұрын
DON'T FORGET TO ➡️ Join the community here: amigoscode.com/p/join-community ➡️ Checkout best premium programming courses: amigoscode.com/courses
@felipedossantos7246 2 жыл бұрын
I know this first code. It was written in Semana DevSuperior in Brazil. The instructor is quite nice, a really smart guy. But it's really awesome when we can see a feedback like this from Mama Samba.
@pedrocarara1830 2 жыл бұрын
omg!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! im the frist one in the video omggggggg!!!! :D :D
@Alberto_Cavalcante 2 жыл бұрын
Boa Pedro
@kristiyangerasimov6708 2 жыл бұрын
Dear Nelson, thank you for the great content. Please do more of these code-review-style videos. As a beginner it is one of the best ways to see different projects through someone's more experienced eyes. Truly invaluable!
@xanxusvaria8492 2 жыл бұрын
we aleykum Selam, a Muslim doing code Videos, damn I am happy to see a brother sharing his knowledge with The World! We need more people as amazing and nice as you representing there religion in such a good manner! May Allah bless your Heart jazakallahu khairan!
@downfall991 2 жыл бұрын
I liked this a lot! Thanks! Would be nice if you could do these types of content from time to time and also explain like how and why it could be better implemented when you don't agree with some of the stuff you review. Or even make a video for best practices, programming principles, designs like package by feature vs package by layer and etc.
@michelchaghoury870 2 жыл бұрын
hello nelson great content, can you show us how to test a secured endpoint in spring boot and how to user swagger with spring security
@ownagejuice1394 2 жыл бұрын
i enjoyed this. you're one of the few YT instructors I respect
@williamokano 2 жыл бұрын
Bro, simply amazing channel. That's awesome that you're doing this public reviews for the people and pointing the improvements. The community needs more people like you.
@Lolnigaaaaaaaaa 2 жыл бұрын
Just look at this guy inspiration for all the Muslims, glad to see this guy following sunnah with prayer cap.
@DevMadeEasy 2 жыл бұрын
Hey amigos code I just loved the "old lady" you used on your Thumbnail, she's in a lot of my own videos. About your video? A great Job as always. Congrants!
@pablon3115 2 жыл бұрын
This is a truly channel for developers unlike other channels that shows any kind of crap except programming itself.
@aykborstelmann8623 2 жыл бұрын
The reason for writing tests is not just to be sure that everything works but also to improve your code. Testable code is usually much cleaner. Just to give you guys extra motivation for testing.
@ogookafor2137 2 жыл бұрын
I LOVE THIS! We need more of this . Thanks Amigos
@eli-tutos Жыл бұрын
I wanted to give a like every time you said "TEST YOUR CODE". KZfaq is full of guys teaching bad practices so this video is GOLD. I'll save it for future reference.
@vrvr82 2 жыл бұрын
I strongly disagree on 2 points: 1) There is no bad thing about using Instant, it's part of Java 8 Date/Time API as LocalDate. 2) The bad practice in repositories is actually to write a @Query when it can work automagically thanks to the method name (I really don't understand why would that be a wrong practice tbh)
@sinamarki 2 жыл бұрын
Im agree with you. I use @Query only for complex query or optimisation and instant is not a bad practice
@tyvain 2 жыл бұрын
@@sinamarki yes, use the power of jpa without typing the query most of the time is great / easy / readable
@xxcsokixx 2 жыл бұрын
Yes please. Dont write unnecessary queries...
@DavisTibbz Жыл бұрын
Yes
@jorgerst Жыл бұрын
This. Thanks for also pointing that fact about the unnecessary @Query annotation.
@istainblack 2 жыл бұрын
This content is awesome! I really enjoyed this video. Its really cool to get an inside look into what is going through an experienced developers mind in a code review!
@user-lb2bg2im9e 2 жыл бұрын
I learn english by watching your content, thanks for your efforts! From Russia with love ❤
@KolosBros 2 жыл бұрын
awesome video! This is the best way to learn how to properly write code ! It's awesome to learn good practices from such pro as You! Please do more in the future !
@markojozic3944 2 жыл бұрын
Really good advice. You always have to remember that the Tech-Lead is not the one who is hiring you but he has to defend your application and if you follow Amigos advice you make it very easy for somebody to defend your position.
@Lucas-ej1si 2 жыл бұрын
The "olá, tudo bem?" made a big smile on my face, thank you
@bogdanspirea9050 2 жыл бұрын
Why is it considered a bad practice not having @Query on top of the methods in the repository?
@Quillraven 2 жыл бұрын
I also did not get that. Why define a query when spring is automatically doing it for us? I get it for complex queries but for simple ones I personally prefer it without @Query unless someone has a good reason for it.
@theyreMineralsMarie 2 жыл бұрын
It's not bad practice, it's just his opinion. Not everything this guy says is law.
@TheN0odles 2 жыл бұрын
@@Quillraven Agreed
@user-stevegjffuhdry 2 жыл бұрын
I usually skip most of your videos, but this one was an eye catcher. You should keep on doing this type of format. Another idea to consider, you do an open source project with fans and do code review/coding sessions with them.
@ThiagoLimaRocks 2 жыл бұрын
I have been working on Software Development for the last 8 years and I never had a code review. Recently I have been promoted to be a tech lead, and I didn't know how to do code reviews. Please, do more of this, and maybe I'll learn how to work better. Thanks.
@shiningass 2 жыл бұрын
LGTM
@mishikookropiridze 2 жыл бұрын
Looks good 👍
@LeadNevertell 2 жыл бұрын
@@shiningass HHAHAHAHAHAHAHA That killed me.
@renanbrayner984 2 жыл бұрын
1:53 that "olá, tudo bem?" was soo smoooth
@diogoluizzzzzz 2 жыл бұрын
Greetings from Brazil ! Congratulations for your content, it has helped me a lot! I don't understand English very well, but your diction is very good and you don't speak super fast like other people lol, so I can follow your content more easily! thank you !
@plankton383 2 жыл бұрын
Code reviews are my favorite programming content on the internet. Subscribed. Please do more! 🙏🏻
@lucasfrancisco1502 2 жыл бұрын
I'm from Brazil and your "Olá, tudo bem?" was perfect. Congrats! You have a little of brazilian in your life.
@spiritofliquid 2 жыл бұрын
The IDE has also the option to optimize the imports for you when u commit something in your repo. I saw so often unused imports....
@Influras 8 ай бұрын
This channel is a gem for the java community
@ogwokwilliam3891 2 жыл бұрын
am a MERN developer - this is the most helpful content I've found all month. Thanks alot
@OlajhideyYT 2 жыл бұрын
From this video, i am so guilty of not writing test. from henceforth imma start writing test
@yasmin_jsmn 2 жыл бұрын
I wish I had the chance to see code review like this earlier in my career. You are doing a great job جزاكم الله خيرا. I have a question please, why it's not good practice to have an interface for each service? Without interface you're depending on implementation not abstraction.
@zlarak 2 жыл бұрын
Completely agree with you. Having dependencies in the constructor is nice, but Dependency Inversion requires you to reference an Interface and not the implementation itself. Otherwise you're introducing unnecessary coupling to that one implementation. Interfaces also are usually easier to mock during tests.
@31redorange08 2 жыл бұрын
@@zlarak No, no interface required. Unneeded bloat.
@YT_Zorro 2 жыл бұрын
The @Query is usually the bad practice in this case when using JPA. Only use @Query if JPA cannot make the query you are trying to do. Also wrap your repositories in service layers for cleaner implementation.
@DavisTibbz Жыл бұрын
Yep i agree ☝️
@exprove2496 2 жыл бұрын
It's wrong to catch every `Exception` at 6:00, since there are many things that could go wrong. However I think you should catch a custom service exception NotFound (or findById exception if it already throws a DoNotExistException) on the controller and return a HttpStatus.NOT_FOUND. I don't use Spring for years but I don't think IllegalStateException will automatically map to a 404 response. Normally unhandled exceptions will throw a 500 internal error on webservers.
@fauzrukendworld1633 2 жыл бұрын
I don't know Spring but on my projects I usually use some kind of exception event or at a higher level than the actual action that does this exception conversion from Not Found from the ORM to the HTTP 404 exception. This avoid having to repeat the try catch in all the controller actions I might have.
@vinaychaurasiya719 2 жыл бұрын
i encountered so many problems in my project just by watching this video, thank you so much sir.
@FedericoFavaro 2 жыл бұрын
Hi there, great video there, enjoyed watching it a lot. If you want to make this format even better, you could go a bit more in depth about why things are not working. Well, maybe not naming conventions because they are just conventions, but say: - constructor injection -> you say multiple times to use it over field injection, but you never explain the reasoning behind this - exceptions in controllers -> you say not to throw exceptions in controllers, but never explain why that should be avoided And so on. Basically, I feel like this type of content could have GREAT potential, but that it calls for a more in-depth analysis
@dabbopabblo 2 жыл бұрын
Your sense of fashion is amazing dude, also props for being so informed and knowledgable
@asandax6 2 жыл бұрын
The money using double or float problem is real. I've seen too many students use it when I help them with assignments. The most infuriating thing about this is that most when I ask to see the books they are using it's written that never use floats to do financial calculations and give examples of why.
@ParadoXxGER 2 жыл бұрын
You have a very positive influence on our coding-community. Nice work!
@somdaarnaud 2 жыл бұрын
Please do expand on the feedback you make so people know why doing 'xyz' is not a good idea rather than just this is not good practice, helps strengthening the point as to what can happen if this is not done. Appreciate the video though, one of the most informative ones I've seen in my career!
@andreujuanc 2 жыл бұрын
"What is this, man? Have some tests!" XD haha that was so good.
@GetDone96 2 жыл бұрын
Incredibly useful, it's like a video version of pull request review. Keep it up!
@jorgerst Жыл бұрын
9:03 - Why "always add the @Query" even if spring boot provides you the implementation based on the method name on many cases?
@tseby1172 2 жыл бұрын
This is incredibly usefull and helpfull especially to someone like me (who has not landed a job yet) to get insights on how things should be
@Japhu 2 жыл бұрын
@ 33:00 not sure what exactly thats doing but creating new threads on runtime is not a good practice in java because of cpu overhead and vulnerability for dos attacks. Always use a threadpool.
@akshayrc 2 жыл бұрын
Great content here.. Thank you Nelson for making one! Please bring more code review videos.
@ourybarry2983 2 жыл бұрын
19:03 In my opinion returning numbers of deleted row isn’t actually a good idea as the method takes a single row id in param it we already know that it will always return 1 in case of success, so i think’s it’s better to return a boolean that will tell if the deletion was successful or not
@anhquantranle961 2 жыл бұрын
yeah return the number of deleted row is actually bad because it is not flexible enough for a change to an interface. Imagine if for example later they decide to change the implementation to another database technology that don't support returning number of deleted row -> we now have to change a lot of code to accomodate that. Besides, returning the number of deleted row is such an unnecessary detail which the dependent class need to know: why number of deleted row but not the data that get recently deleted? why number of deleted rows but not boolean value like you said.
@bonikene 2 жыл бұрын
hello bro... u really did motivate me to come back to coding and it has been my resolution for this year to catch up with some front end and back end programming so far am really loving , enjoying it...programming has always had a soft spot in me but due to career change i have been about 9 years out of thew game and i have been always feeling like now am too old to catch up but i was really wrong.
@blighthornsteelmace820 Жыл бұрын
so, are you coding now?
@kadusalles 2 жыл бұрын
Hey man! :D Awesome video, you could explain more, detailing why he should do it the way you told him.
@marupakasrikarsharma9371 2 жыл бұрын
Hello Nelson! Thanks for sharing great content. I have a doubt, why are we removing @Autowired and adding constructor injected ?
@stevenr3537 2 жыл бұрын
It's switching from setter depending injection to constructor based injection. Constructor based, using final is a immutable dependency injection method, whereas with setter based technically the dependency could be changed after initial instantaniation of the controller
@kaliljanan 2 жыл бұрын
it would be nice if you take some time to explain the diference between DAO and Repository. Also the util folder could be a exemple of anemic domain or primitive obsession.
@31redorange08 2 жыл бұрын
The difference is that they have nothing in common.
@WilliamStoner 2 жыл бұрын
Strongly agree that this is very good educational content, it was entertaining and informative!
@FdcTeamDev 2 жыл бұрын
LOVED THE "OLÁ, TUDO BEM?"
@_baeludo 2 жыл бұрын
Hi, I really enjoyed this video !! Im a QA analyst, actually working on a project used for "make devs to the market" where i do functional testes manually and automated tests and other kind of analysis. I also have been studying api development to create some services to help me automate dynamic scenarios. By looking this video, i also have to comment that in my actual scenario, i started to do some code review on devs code because i've spent lots of time testing and reporting errors that could've been avoided by unit tests. Would you make a code review on my python flask restx apis? I' ve never got a code review from any of my codes and any kind of feedback on it. I've made apis that use webscrap (consuming php service that does not uses any king of pattern struct for service response) to return data as json and also other kind of services just to learn microservices and other stuff. Thanks a lot for this kind of content, i'll be joining your discord soon ✌
@contactdi8426 2 жыл бұрын
This is the best series!! I really liked and learned, please keep on giving these review videos
@arturjoshi8905 2 жыл бұрын
7:04 There is also no need to save entity, as it's being managed by persistence context in @Transactional methods.
@mrcoder9401 2 жыл бұрын
Walaikum as Salam..... Masha Allah , this is great man ,this helped alot analyzing myself. Looking for more such reviews. Thanks!
@lovetocode 2 жыл бұрын
really like this kind of professional code reviews. Would be great if get to see more.
@patrickbelanger6253 2 жыл бұрын
I really enjoy watching these code reviews! I learned a lot watching you review Spring Boot-based app. Well done!
@Sasikumar-kr7xy 2 жыл бұрын
Incredible walkthrough. Insisting more on tests
@waqasshah6331 2 жыл бұрын
wa alaikum as'slaam. your videos are true learning material. Not just beginner level but for some experienced like me. Keep them coming brother. jazakaALLAH :)
@sportsuniverse1303 2 жыл бұрын
Hello Nelson, I think you should do more of this. It's enlightening. Thumps up 👍
@maulanaiman4448 2 жыл бұрын
This is what I often looking for on youtube, the only channel that doing code review is Laravel Daily, it's hard to find a content like this.
@rosuewalford7767 2 жыл бұрын
You can mock the autowired dependencies in your tests there are various ways to do it
@Michaeljamieson10 2 жыл бұрын
please keep doing this! I didnt quite understand why not to have an interface for each service... if anyone can explain it would be appreciated!
@UsernameUsername0000 9 ай бұрын
My understanding is that it’s superfluous because it’s not like you’re going around creating multiple versions of that service. You don’t need a contract for something that you won’t write more than one version of. At least that’s what I think it is. This way you’re forcing yourself to synchronize two classes instead of one, when you only need one.
@OmbasaGeoffrey 2 жыл бұрын
we should have more of this
@aminshoman1 2 жыл бұрын
I am happy you are a good Muslim, proud of you bro, hopefully this content will be Hasanat for you ❤️
@youssefelmoro1464 2 жыл бұрын
we need another video like this Bro
@matrix8934 2 жыл бұрын
IMO, the biggest problem in the first one was using doubles for storing prices
@julianrodriguez9832 2 жыл бұрын
Thank so much for this content, it really helps me get familiar with the backend part of web dev
@WilmanArambillete 2 жыл бұрын
i totally loved this video. It is super useful to have your feedback since you seem to have a lot of experience with Springboot and Java. Kudos for this video
@aadlani 2 жыл бұрын
I can't thank you enough for putting this together. 💖💖 May Allah reward you well
@speedfastman 2 жыл бұрын
Allah's not really rewarding Ukraine rn. 🤕☹😥
@forevermist3838 2 жыл бұрын
@@speedfastman God gave all of us free will and a ruleset of moral obligations to live by. Now just because a war happens or someone close to you dies. You don't blame God you blame the person who used his free will to cause deaths.
@speedfastman 2 жыл бұрын
@@forevermist3838 Why would God be so silly to give us free will when he knows we'll have pain and suffering because of it!
@forevermist3838 2 жыл бұрын
@@speedfastman Without free will you are just a robot, you won't have the ability to make your own choice .This life is not given to us for free, Through out your whole life you are tested. You have the capacity to do good or bad, Hence the reward and punishment according to your actions. You will get reward if you do good things in this life and in the hereafter and for wrongdoers Justice prevails. If not for God you can do bad things and hopefully justice serves but sometimes you get away with it. You don't have a punishment waiting for you in the afterlife and you don't have the fear of being punished by God. Same argument can be put against athiests, Why do humans have the ability to think and make choices? If not then the world wouldn't be so bad right?
@speedfastman 2 жыл бұрын
@@forevermist3838 Is God good and omnipotent? Yes? Then he wouldn't have created suffering. End of story.
@titzko987 2 жыл бұрын
First time Im seeing this kind of content on youtube, but its really good. Please more of it
@noone-gz4pc 2 жыл бұрын
KZfaq brought me here and I'm so happy I found you! subscribed.
@rStudius 2 жыл бұрын
IMO is bad to say that you should not use method naming to query on repository. Because it's documented and it must be used
@coreykuehl8519 Жыл бұрын
Definitely more of these videos. It would be great for them to go a little longer as well.
@420_FORTNITE 2 жыл бұрын
Thank you so much! Please do more of these :)
@gaganok6870 2 жыл бұрын
Hey, could you please cover one of these projects with tests. It is just too unintuitive having a knowledge about mocks and having no idea how to apply it.
@ghodhbaniabderrahmen5433 10 ай бұрын
Bro I like the way you said " WALLAHI I'm disappointed" in 3:26 😁😁😁
@matuschladek8277 2 жыл бұрын
This is perfect concept. If anyone know about similar video but reviewing Python, let me know please!
@anthonydedios6698 2 жыл бұрын
Please upload more of this. Thank you @Amigoscode
@SealedSaucer 2 жыл бұрын
The algorithm have blessed your channel.
@lukagolubovic3641 Жыл бұрын
Please do some more videos of this type, they are very useful and it is secured to have at least 150k+ views because people are looking into watching and learning from videos like this one. Thank you
@carlosrenesoto9650 Ай бұрын
Great video! I Always learning new things from watching your videos. Regards from Tijuana, México
@faisalalghamdi2066 2 жыл бұрын
Really enjoyed watching this. Great stuff, thanks!
@testaenzo620 2 жыл бұрын
Nice video ! Can anyone explain why controllers should not throw errors, but only services should ?
@javohiruralov1812 2 жыл бұрын
Thank you Nelson very much. Keep going 😎👍👍
@squ34ky 2 жыл бұрын
This video is amazing! Got to learn so much from reviews. Thank you!
@lennart5738 2 жыл бұрын
Since you read books by Robert C. Martin you should be advocating for a functional package layout rather than a technical package layout
@RondellKB 2 жыл бұрын
Can you do a video on productivity in Intellij? Like useful keyboard shortcuts, and the thing where you have multiple cursors.
@iiikawaiii9098 Жыл бұрын
I stumbled upon your video by accident, why didn't I do this earlier?? Your content is the best I have ever seen. And yet, what are your background configurations and so on? The appearance of the IDE with the code makes the eyes happy
@oscarmiranda9532 2 жыл бұрын
Hey Salim, (Sorry if that isn't how you spell your name), but you should considered a video where you explain architecture on how to build our projects
@awli8861 Жыл бұрын
I havent wrote a single test in my life.
@edwinsulaiman6143 2 жыл бұрын
I don't use java, but c# (ASP.net core). I learn a lot from this video and gonna apply it to my code, thank you so much
@ernesttomas9358 2 жыл бұрын
I'm working at a company that tests every line of code we write!! Hahahaha hope this makes you happy
Gufee.medalin
Рет қаралды 5 МЛН
CallFluent AI
Рет қаралды 1,1 М.
Sameer Gaming
Рет қаралды 2,3 МЛН
Immersed
Рет қаралды 9 МЛН
Special Effects Funny 44
Рет қаралды 1,7 МЛН