No video

Why Didn't He Get the Job? Let's Find Out! // Code Review

  Рет қаралды 102,441

The Cherno

The Cherno

Күн бұрын

To try everything Brilliant has to offer-free-for a full 30 days, visit brilliant.org/... . You’ll also get 20% off an annual premium subscription.
Patreon ► / thecherno
Instagram ► / thecherno
Twitter ► / thecherno
Discord ► / discord
Code ► github.com/Dim...
PowerShell wxwcution policies ► learn.microsof...
Hazel ► hazelengine.com
🕹️ Play our latest game FREE (made in Hazel!) ► studiocherno.i...
🌏 Need web hosting? ► hostinger.com/...
💰 Links to stuff I use:
⌨ Keyboard ► geni.us/T2J7
🐭 Mouse ► geni.us/BuY7
💻 Monitors ► geni.us/wZFSwSK
This video is sponsored by Brilliant.

Пікірлер: 559
@TheCherno
@TheCherno Ай бұрын
Your move, Дмитро. Don’t forget you can try everything Brilliant has to offer-free-for a full 30 days, visit brilliant.org/TheCherno . You’ll also get 20% off an annual premium subscription.
@raffiepro
@raffiepro Ай бұрын
I agree, Дмитро should learn some basic maths from brilliant
@makesnosense6304
@makesnosense6304 Ай бұрын
Could it be that the Debug runs the TestApp, Release runs the "real" game?
@JavedAlam-ce4mu
@JavedAlam-ce4mu Ай бұрын
I wonder if he was trolling?? Quite an elaborate troll if so.
@connorskudlarek8598
@connorskudlarek8598 Ай бұрын
"Just give me the .exe"! Basically that.
@RPG_Guy-fx8ns
@RPG_Guy-fx8ns Ай бұрын
Cmake is gross, and silently installing dependencies is disgusting. All of this is terrible security. I would rather not have any software auto update. Cmake needs to be replaced with something simpler and safer.
@MaxTheDragon
@MaxTheDragon Ай бұрын
Pro-tip: Always try to build your project on a completely different computer before you submit it.
@dummyaccount1706
@dummyaccount1706 Ай бұрын
Or on a VM
@strider3438
@strider3438 Ай бұрын
​@@dummyaccount1706containers though?..
@rafal9ck817
@rafal9ck817 Ай бұрын
I just set up Jenkins CI/CD and have it built in docker runner
@strider3438
@strider3438 Ай бұрын
@@rafal9ck817 yep yep
@MrSofazocker
@MrSofazocker Ай бұрын
Its so easy to make a dockerfile to build, especially when you do cross-platform. Essential for running tests on each platform
@Syndiate__
@Syndiate__ Ай бұрын
This is a prime example of "It works on my computer"
@RemoteAccessGG
@RemoteAccessGG Ай бұрын
Not using Docker, the best tool in the world moment
@imo098765
@imo098765 Ай бұрын
@@RemoteAccessGG it works on my computer, then gives entire docker container of computer
@mattboemer4549
@mattboemer4549 28 күн бұрын
@@imo098765ez
@nexovec
@nexovec Ай бұрын
On his way to a complete game, he forgot how to run the game.
@nijucow
@nijucow Ай бұрын
he forgot the basics while trying to impress the reviewer with fancy stuff
@ibrahimhussain3248
@ibrahimhussain3248 Ай бұрын
Or a VM
@kewqie
@kewqie Ай бұрын
You weren't harsh at all tbh, even as a friend or colleague I would be like "dude, shit ain't working".
@ProGaming-kb9io
@ProGaming-kb9io Ай бұрын
The game is the build we fixed along the way
@nitinrawat4522
@nitinrawat4522 Ай бұрын
lol XD
@luffytaro-tg1gm
@luffytaro-tg1gm Ай бұрын
@@nitinrawat4522 🤣
@Darqonik
@Darqonik Ай бұрын
😂😂😂
@martinmetskula6384
@martinmetskula6384 27 күн бұрын
😂
@zissler1
@zissler1 6 күн бұрын
That's deep
@mattiapezzano1713
@mattiapezzano1713 Ай бұрын
Harsh but deserved, as an applicant you must act as if you were advertising yourself, straight to the point, you gotta give an easy path to the good stuff to the interviewer.
@Schwuuuuup
@Schwuuuuup Ай бұрын
And if you bit off more than you could chew this is a huge red flag for the interviewer as well. I'll take a small project that runs over a project with huge ambitions but doesn't compile any day
@abuDA-bt6ei
@abuDA-bt6ei 24 күн бұрын
Yes the interviewer, the one who is already a professional should have it made easy, because figuring out how to compile and run programs never happens on the job. Maybe the interviewer just lost a promising programmer due to their incompetence in figuring out the problem.
@xXCheapTofuXx
@xXCheapTofuXx 23 күн бұрын
@@abuDA-bt6ei Imagine this, you go to the mall to buy a shirt, you don't really care about the brand you just want a good quality shirt. There are 100s of stores at the mall. You walk down the path and start smelling shit, then turn your head and see a store that's flooded with sewage water, the sales rep assures you that they store their products safely in a vault in the back and they have the best quality shirts in the mall! Would you go in or just try one of the 100s other stores that are not covered in shit.
@abuDA-bt6ei
@abuDA-bt6ei 23 күн бұрын
@@xXCheapTofuXx If that shit covered store truly did have the best shirts and I went somewhere else, I would’ve missed out on the best shirts. If getting the best shirts meant the success of my totally legal offbrand shirt selling company, then I just missed out very on much profit, all because I made my decision off a first glance and didn’t even look at the product itself..
@xXCheapTofuXx
@xXCheapTofuXx 23 күн бұрын
@@abuDA-bt6ei you will never get to buy your shirt if you have to spend 20 minutes in 100 stores. Your problem is that you don't see the bigger picture. You want the BEST shirt in the mall in the LOWEST amount of time. Cost/Benefit. If you go into the shit covered store you HAVE to also go into every single store. So instead of buying a shirt that day you will spend the next week shopping and going into every single store. Whereas you could have gotten a really really good shirt in 1 hour. You do this yourself everyday. You want a new phone? are you going to spend years reverse engineering every single phone on the market so that you understand every single part, or are you just going to act on face value and known facts. you probably bought an android because "apple sucks" but did you spend 5 years learning every single function of code inside the apple device so that you can come to the conclusion that its bad or did you just take it at face value that apple is a shit company. again, you would never have a phone then.
@bladman9700
@bladman9700 Ай бұрын
"Please roast code at full capacity" Shouldn't have said that blud
@varunfighter4871
@varunfighter4871 Ай бұрын
the roast went so hard we barely got to the code part
@w花b
@w花b Ай бұрын
​@@varunfighter4871 when the rest is so roastable you can't even get to the main part
@scififan698
@scififan698 Ай бұрын
I always hate it when job applicants assume confidently that their code will be good enough for a roast, while I can spot a pile of garbage from a mile. It's insulting.
@nijucow
@nijucow Ай бұрын
That's not a code review. That's a code roast 🤣
@wakannnai1
@wakannnai1 Ай бұрын
I don't think it's even that. He never even got to the code since it's a nightmare to build...
@prashant4174
@prashant4174 Ай бұрын
Which code? I see no code, all I see is powershell and build errors.
@呀咧呀咧
@呀咧呀咧 Ай бұрын
It’s a build system review
@px2059
@px2059 Ай бұрын
there was no code dawg
@nexovec
@nexovec Ай бұрын
It's a no-code review, lol
@GamingDemiurge
@GamingDemiurge Ай бұрын
While I agree on every single point you make. I will like for everybody to step back and appreciate how ridiculous the build process is in C++. It is absolute madness. CMake was created by a completely insane person. It is important for juniors to realize that they are not stupid. The system itself is crazy. You don't have to learn just the language. You need to learn about toolchains. different compilers, ... . In mid to big projects you will have people just dedicated to maintain the build system. It is wasteful, unnecessary, and stupid.
@ea_naseer
@ea_naseer Ай бұрын
we had that in java or so I heard then we all duked it out with Maven. Call Stroustroup
@ColinBroderickMaths
@ColinBroderickMaths Ай бұрын
You pay a price for the complexity and power (and admittedly historical baggage) of these languages. While I understand your criticism, I can't really fully agree. The basics of CMake are simple and easy, and the basics are all you need for a project like this. A minimal CMakeLists.txt is like four or five lines. Then it's just "paste this bit to add this dependency". I haven't checked the websites but I bet all the dependencies used had something like "insert this shit in your CMakeLists.txt to use this library". Seems like this person massively overcomplicated this work to their detriment. If CMake is too much for this beginner, they would have been much better off just saying "install this dependency" and then sticking with a raw VS solution. I would accept that from a junior without another though - I know they don't know everything yet. They shot themselves in the foot by massively overdoing it, and doing it very badly, and making everything more difficult for the reviewer.
@user-sl6gn1ss8p
@user-sl6gn1ss8p Ай бұрын
I'm mildly allergic to cmake, but I've found premake to be way friendlier. Not always an option, of course.
@CodeStructureTalk
@CodeStructureTalk Ай бұрын
Yeah, the CMake sometimes works, but it's not very well integrated, you still need to keep notes how to run it because of -G, -T, debug flags, etc. Each OS still requires it's own defines. There are legacy and nonlegacy parameters, static and dynamic linking, symbols, it's not easy to use. And the point about having one person dealing with CMake is exactly right. One person on CMake, one on Docker, one on CI, and then we wonder why everything is buggy and takes so long to develop.
@daven9536
@daven9536 Ай бұрын
And this is exactly why this has no business being part of the evaluation. The applicant doesn't know anything about the interviewers system (and the potentially very restrictive IT policies placed upon it). It is complete nonsense to expect someone to provide a one-click solution in the complete and utter clusterfuck that is the C++ ecosystem. Imho the interviewer should provide a minimal project for the applicant to build their stuff with. Then the jumping through hoops part is placed on the applicant and things are guaranteed to work out without too much of a hassle.
@hanes2
@hanes2 Ай бұрын
I always try to make it a three step process in the readme… 1. Git clone 2. Cd; build 3. Run
@severgun
@severgun Ай бұрын
Sounds like Go project
@phee3D
@phee3D Ай бұрын
@@severgun sounds like a normal, well designed project in any language/system.
@and_then_I_whispered
@and_then_I_whispered Ай бұрын
How about no steps at all. As soon as he opens the email, everything runs automatically 🦴 (yeah, I tried to type skeleton to get ☠️, but you get it).
@dagoberttrump9290
@dagoberttrump9290 Ай бұрын
git clone conan build ./build/release/myapp.exe
@oguretsagressive
@oguretsagressive Ай бұрын
@@phee3D ever tried to build Chromium? Or Pytorch? Tensorflow?
@soniablanche5672
@soniablanche5672 Ай бұрын
new series: Build review
@sherazali8691
@sherazali8691 Ай бұрын
I always run my code on someone else's machine to check if it throws any errors. Most of the time, what happens is that we have all of the required tools installed and configured on our machine and when we give the same code to someone, it simply doesn't work due to some missing installations/configurations.
@EmiliaHoarfrost
@EmiliaHoarfrost Ай бұрын
Can you not instead use a virtual machine?
@MrSofazocker
@MrSofazocker Ай бұрын
​@@EmiliaHoarfrostYes, yes you can! But honestly just setup Docker and run all your build and tests on all platforms you target no more surprises
@sherazali8691
@sherazali8691 Ай бұрын
@@EmiliaHoarfrost Yes you can but for me it's more convenient to test on some other machine.
@tokarevart
@tokarevart Ай бұрын
@@MrSofazocker docker is not a VM, can't emulate a whole operating system, so you can't check whether your app runs on windows if you're running docker on linux (and if you're running docker on windows it seems you're just running docker inside linux VM)
@elcugo
@elcugo Ай бұрын
Yeah, but if your friend's machine also have installed an undeclared dependency then you'll still miss it. It's better to test in a clean environment to be sure IMO.
@danleedev
@danleedev Ай бұрын
I interview coders as part of my lead dev job, and I would say that my tolerance for the state of this submission would be entirely based on the level of the role. If I was hiring a junior, I would pass the code to one of my intermediates and have them debug and configure the code to something I can evaluate. Anything higher than junior, and I would reject the submission.
@Dom-zy1qy
@Dom-zy1qy Ай бұрын
Tbh I just assumed universally everyone would instantly reject anything they can't immediately evaluate.
@CarKiller92
@CarKiller92 28 күн бұрын
Yeah, especially today's job market, any small red flag just means instant rejection.
@ScorpioHR
@ScorpioHR Ай бұрын
This code was sponsored by IKEA. You need to assemble it yourself
@peterholzer4481
@peterholzer4481 19 күн бұрын
But Ikea's instructions work.
@ricky2629
@ricky2629 Ай бұрын
Powershell is actually cross-platform, and has been for a while. But that still doesn't explain using it for a build step where all you do is call cmake.
@onejdc
@onejdc Ай бұрын
Don't put friction between you and the interviewer. Not an exact quote, but man, that nails it. You could have the most beautiful code on the planet, but if you make the interviewer jump through a bunch of hoops, you've already put yourself at the back of the line.
@wazreacts
@wazreacts Ай бұрын
I invite everyone to change speed to 0.5x for Cherno's "drunk code review"
@mspeir
@mspeir Ай бұрын
🤣 OMG!
@onionknight249
@onionknight249 Ай бұрын
Damn it feels real😂
@RaveYoda
@RaveYoda Ай бұрын
Wow
@shulehr
@shulehr Ай бұрын
well, i watched at 1.5x
@cabji
@cabji Ай бұрын
I noticed how rapidly "Cplusplus" kept spitting out of his mouth
@collwyr
@collwyr Ай бұрын
being asked to make doodle jump as a code test wouldn't surprise me, about 4 years ago I was asked by one company to write my own animation system in unity and they didn't allow me to use any of the libraries in Unity to assist with it, and this was a fresh out of Uni job post and application.
@and_then_I_whispered
@and_then_I_whispered Ай бұрын
Did you get it?
@MrStaples441
@MrStaples441 Ай бұрын
small game dev team just needed an animation system and used you to write one ;)
@collwyr
@collwyr Ай бұрын
@@and_then_I_whispered I didn't even bother attempting it, I had three other job assignments that were far, far more reasonable to do and made sense, they emailed me like a week later asking how I got on and I told them I wanted to withdraw and focus my attention on other applications. in case anyone is interested the other assignments I were given were games that I had to both add additional gameplay aspects to and find and solve bugs in the current version of the game. far, far more enjoyable tests that actually tried to understand my level of programming expertise.
@collwyr
@collwyr Ай бұрын
@@MrStaples441 generally what I thought they were trying to do, I was very conscious of this potentially happening when I was applying for the lesser known/lower workforce game companies. the thing is, if they didn't explicitly forbid me from using the libraries Unity has to assist in making the animation system I probably would have given it an attempt as it would have been an interesting learning experience, but I had far better job applications at the time that actually made me excited to do.
@unitydev457
@unitydev457 Ай бұрын
@@collwyr yeah this actually sounds like a really fun unique challenge, but I had the same thought regarding them trying to outsource free work from interview candidates
@vaclavsimak502
@vaclavsimak502 Ай бұрын
The fact that there are 61 source files makes me think that there might be hidden actual game somewhere. No?
@ColinBroderickMaths
@ColinBroderickMaths Ай бұрын
You may well be right, but sadly from the perspective of the interviewer it doesn't even matter. There are far too many excuses to throw this application in the trash before you even get to the game.
@TehIdiotOne
@TehIdiotOne Ай бұрын
Yeah the game is probably there, but if an interviewer has to run through this many hoops to get it to work, then you've already failed.
@ragnarok7976
@ragnarok7976 Ай бұрын
​@@ColinBroderickMaths Yeah if I were the interviewer this would be an omen that my colleagues and I would likely be spending a lot of time polishing his turds. Kudos to him for trying but he's got a lot to learn. Might actually get a critique back from the employer if they could actually build/run it lol
@blablabla7796
@blablabla7796 Ай бұрын
This is why all my projects have CI/CD pipelines that automatically sends a random person from Fiverr a request to install and run my program. It also sets up a video conference call using an AI avatar to check if they were able to do it successfully. On pipeline failure, it sends a command to a Raspberry Pi to send me a gentle electric shock to wake me up from sleep so that I can start working on the project. This is naturally set up to run on pre-merge as well as on a nightly schedule.
@JavedAlam-ce4mu
@JavedAlam-ce4mu Ай бұрын
I have a strong suspicion that was some strange form of elaborate code trolling...
@gasun1274
@gasun1274 Ай бұрын
Never assume malice when incompetence explains it
@sanderspeetjens
@sanderspeetjens 21 күн бұрын
A big red flag is also not using version control (git), can be seen by the commit code space copy The best way to build cpp projects in my opinion is creating a build/run docker container
@aboliguu1168
@aboliguu1168 Ай бұрын
This is so C++, spend the whole video trying to get the build system working 💀 Edit: but hey can you make another video where you look at the code? It would be interesting
@marcotroster8247
@marcotroster8247 Ай бұрын
Gosh, this reminds me of this stupid uni assignment where I spent half a year building this Unreal Engine car simulator because I had to do a source build to load the damn custom vehicle of my supervisor into the simulator. It was like Docker calling Bash calling CMake calling C# calling clang. Like how ridiculous can you make this stupid build pipeline?! This crap build process ran like 3 hours and generated 300GB whereas only 12GB were actually needed to run the game. Gladly it was not my PC and the SSD survived somehow.
@theforeskinsnatcher373
@theforeskinsnatcher373 Ай бұрын
If set up correctly, building a C++ project should be as simple as typing "cmake " and then "ninja" or "make" or whatever you use
@marcotroster8247
@marcotroster8247 Ай бұрын
@@theforeskinsnatcher373 Yeah, I'm setting up proper CMake for my own projects as well like any sane C/C++ developer would.
@ColinBroderickMaths
@ColinBroderickMaths Ай бұрын
The small snippets we saw looked pretty bad, so it would be another roast for sure. I don't even mean the code necessarily, just the sheer volume of code/comment detritus that was littered around not doing anything. From the perspective of an interviewer, that looks extremely sloppy and I would not be keen to hire that person when I have a hundred others waiting for a chance. Honestly given how poorly they seem to understand their compiler and build system, I'm surprised and perversely impressed that this person ever managed to get the game running at all.
@ColinBroderickMaths
@ColinBroderickMaths Ай бұрын
@@theforeskinsnatcher373 Yeah, arguably that's all that CMake is really for. To automate all these complicated build preparations so the user doesn't have to worry about it.
@glewfw7989
@glewfw7989 5 күн бұрын
petition to cherno to make an entire video on his native language just to see how different and intimidating he could sound.. like this for happening
@_CJ_
@_CJ_ Ай бұрын
I think that everyone of us was there. Everything works fine in IDE... then you try cmake or some standalone build and there is rabbit hole of fails and errors. Nevertheless that is lesson and you have to test, nowadays it is easy to just fire up sandbox or other virtual machine and try there on clean system. One command to build, one command to run. I would even consider unpopular way with adding executable with warning (if you already have powershell scipts it does not matter :D )
@tolkienfan1972
@tolkienfan1972 Ай бұрын
I was given a coding task many years ago. I had a key insight, and selected a linked list, because I knew the distribution of inputs in the real world data meant that almost all the activity was modify/insert/remove at or very near the head of the list. At the interview I completely forgot to mention it! 🤣 Without that understanding a red black tree or similar would be a much better choice. Despite that I got the job 😁 Still there 16 years later
@oleksiistri8429
@oleksiistri8429 Ай бұрын
9:46 "well, python.. it's LIKE a programming language.." lmao🤣
@user-ov3ef2eo1j
@user-ov3ef2eo1j 23 күн бұрын
Python is imposter.
@CharlesBallowe
@CharlesBallowe Ай бұрын
That README almost looks like the assignment. The email has a bunch of "English isn't my first language" constructs but the readme is basically perfect and well structured and seems to be describing "what the project needs to do".
@ShishirTandale
@ShishirTandale Ай бұрын
chatgpt
@Ginto_O
@Ginto_O Ай бұрын
That's just an AI
@paultapping9510
@paultapping9510 29 күн бұрын
yeah, that's how my bootcamp requires readmes to look. hundreds of lines of 'what is this project' before anything technical.
@t6ixfury
@t6ixfury Ай бұрын
I just finished my BS in Computer Science and currently prepping for job interviews. The information explained was valuable. This was a great help. Thanks!
@OREYG
@OREYG Ай бұрын
The worst part of it, is that half of those problems are inherent to the modern C++ build pipeline. Even with more steps added if you're using Conan or the likes. The fact, that CMake is de facto standard build system is a tragedy.
@antongrant8827
@antongrant8827 Ай бұрын
Actually, at least in Ukraine, it’s a common practice to give a person some sort of a test assignment, to check for technical skills before inviting to the interview. My task, for instance, was to write a pong game :)
@musashi542
@musashi542 Ай бұрын
whats the job title ?
@antongrant8827
@antongrant8827 Ай бұрын
@@musashi542 it was for a junior c++ developer position
@mgoonga
@mgoonga Ай бұрын
I remember spending the whole week-end(like 25 hours) to write a copy Tank 90 Dandy game with QT. Another week-end was spent on small copy of MS Paint. I was a "switcher" with no work experience and was ready to accept any challenge. It was a hard time!
@mikolash8246
@mikolash8246 Ай бұрын
@@mgoonga I would not agree to do such a huge test assignment. In my opinion, the approximate time to complete a test task should not exceed 4 hours.
@mgoonga
@mgoonga Ай бұрын
@@mikolash8246 Sure, one needs to be desperate to take such assignments. I was taking any assignment because there was not much choice and I was dying to switch to c++ programming. Now, 7 years latter, I work for Samsung as a Senior C++ dev in Advanced graphics department.
@PaulEmsley
@PaulEmsley Ай бұрын
Not harsh at all. If I had a project for which I wanted feedback from a colleague - this is how I would want it.
@fkeyzuwu
@fkeyzuwu Ай бұрын
day 723 of cherno not actually reviewing code in a code review video 👍🏻
@bobsemple9341
@bobsemple9341 Ай бұрын
Make you're shit easier to build and he might?
@gianluca.g
@gianluca.g Ай бұрын
"it works on my machine" (tm)
@sebastianschneider326
@sebastianschneider326 Ай бұрын
This is a very interesting code review because coding is actually just a part of being a software engineer. I know so many people who know great features about the language but don't have a clue how the build system works (or vice versa) and this often leads to very messy projects. Tip from my side: Try to deploy the code to various target platforms in one step, this will "force" you to understand how a build system works and how to write target independent code and leverage the build system instead
@thomasjespersen2399
@thomasjespersen2399 Ай бұрын
Very much agree. You can't just always take the toilet paper-roll approach to every project and zoom in on your daily duties, disregarding the rest of the flow (QA, wink, wink anyone?). However, for an interview code test/project?
@nandakoryaaa1401
@nandakoryaaa1401 19 күн бұрын
You will use whatever build system is already used in the company, it's set up in one day and does not deserve that much attention.
@sebastianschneider326
@sebastianschneider326 18 күн бұрын
@nandakoryaaa1401 I am working in an embedded environment and every 2-3 years, when we start new projects, we have to setup a complete new environment based on the product needs. And we as developer are making the decisions.
@nandakoryaaa1401
@nandakoryaaa1401 18 күн бұрын
@@sebastianschneider326 then make a decision, no problem. You don't have to show your decision to some random guy on youtube to be approved.
@chudchadanstud
@chudchadanstud Ай бұрын
Imagine having to do work for your interview. > Umm can you spend your week making this game thank you! >Uhmmm no. No wonder game devs get abused. You guys need to stand up for yourselves.
@gagaxueguzheng
@gagaxueguzheng 7 күн бұрын
When my current employer asked me to do homework, I declined politely and got the job.
@MrMichalXXL
@MrMichalXXL Ай бұрын
what is this bs, asking why you didn't get hired while getting your game to run feels like a project of itself
@dusha3030
@dusha3030 Ай бұрын
Am I the only one that finds crazy the fact that you should have projects on your resume AND need to make a small project for the company to even get a CHANCE of getting the job ?
@ea_naseer
@ea_naseer Ай бұрын
CS is a field that's weird like that
@eucalypt444
@eucalypt444 Ай бұрын
and yet theres still morons running rampant so maybe it should be stricter
@and_then_I_whispered
@and_then_I_whispered Ай бұрын
I don't think he had projects on his resume.
@urugulu1656
@urugulu1656 Ай бұрын
can we just admire how that code compiler w/ 0 warnings or errors? he atleast hasvdone something right ( atleast the one time you build inside of powershell
@scififan698
@scififan698 Ай бұрын
No. And you forgot a closing bracket. lol
@uNiels_Heart
@uNiels_Heart 23 күн бұрын
Well, let's just hope they actually have all the usual warnings enabled and then some. It could easily produce 0 warnings by disabling them.
@Psanyi42
@Psanyi42 Ай бұрын
Honestly having myself spent multiple days debugging why a github project would not build for home project; as an interviewer I would not have went for the trouble to try to fix it, but at least I would have given them a chance like Cherno is giving now, that "look this has to be a one click build for me, please fix it".
@daven9536
@daven9536 Ай бұрын
This is an impossible task. "One click" builds that work on all system configurations don't exist in C++ (if they did, people would use them). If you think that is not true, then you just haven't seen enough. If you managed to do it in the past, you were just lucky.
@Psanyi42
@Psanyi42 Ай бұрын
@@daven9536 So you are saying everyone spends hours to try to get running these interview assigments? I think you are in the wrong here. I understand that it could be hard but here we are talking about visual studio on windows. Everything should be just recognized automatically at least that is my experience with that. Of course if you want to build something with XY additional function obviously you have to make those changes, but if you want to build something you shouldn't have to run 6 different scripts and fix error messages.
@Riya-zj2mk
@Riya-zj2mk Ай бұрын
​@@daven9536even if we have two builds, we can write a wrapper build to conditionally execute one of the builds based on os
@bobsemple9341
@bobsemple9341 Ай бұрын
​@@daven9536skill issue
@Volian0
@Volian0 Ай бұрын
I miss code reviews of small projects written from passion, not for work
@anthonysteinerv
@anthonysteinerv Ай бұрын
Which he also didn't reviewed because he didn't liked the readmes or didn't build, and talked half an hour of building and readmes, this "series" Is a joke now. Just cherno farming videos.
@bobsemple9341
@bobsemple9341 Ай бұрын
​@@anthonysteinervyou're just mad. If you can't make a decent project just admit it lol.
@daphenomenalz4100
@daphenomenalz4100 Ай бұрын
@@bobsemple9341 ngl but this a project in C, and it's inherent to be longer to setup and is pretty hard too if the guy didn't know about containers.
@maervo4179
@maervo4179 Ай бұрын
Who the fuck writes doodle jump from scratch for a job? I would never do that lmao 😂
@Mariuspersem
@Mariuspersem Ай бұрын
I have seen worse build steps and environment setup at my current workplace, this is easy in comparison
@samljer
@samljer Ай бұрын
the hair is an entity of its own.
@CodeStructureTalk
@CodeStructureTalk Ай бұрын
Can we take a moment to appreciate how awfully ridiculous the C++ build system is? In the old days Visual Studio would just use the project files that work out of the box, now you need to deal with CMake, Ninjas, vcpkg, etc. And it doesn't get any easier since there are always problems with static/dynamic, flags, defines, etc.
@velho6298
@velho6298 Ай бұрын
Worked out of box lmao Vc++6 was not that good
@goczt
@goczt Ай бұрын
Huh? VS and CMake have nothing to do with that really. You can still just download the dependencies manually, add them to your VS soulution, zip it and send it wherever you want IF you don't care about what CMake/Ninja/vcpkg are trying to solve. People used to do that, and now same people don't want changes to C++ because it will break compatibility with their 20 year old .dll's that they have no way to rebuild since they lost the source code or whatever. It's just the requirements changed over time and people desire easier dependency management (because we don't want to redistribute zips manually between 100+ developers in the team, and a hotfix 1 day later in a similar manner), easier cross-platform builds (because Windows is not the only OS that exists and is bad for a lot of applications actually), independence from VS (because some of us prefer other compilers and code editing capabilities) and so on.
@victotronics
@victotronics Ай бұрын
1:39 The whole repo is one commit. Big red flag. I probably commit twice a day if I'm working on a project.
@paradoxicalcat7173
@paradoxicalcat7173 28 күн бұрын
Number of commits don't mean crap! I had this argument with my client just the other day! I only push what works; not any crap that I just added 3 lines of code to.
@XeZrunner
@XeZrunner Ай бұрын
I love this video. No hard feelings towards the person that made the project. People generally need to take a step back and "unlearn" some of the complexities for their projects. The ways I see it: people have built some incredibly complex tooling and frameworks over the years that are way too overkill for smaller projects, yet people rely on them to start out. Instead of using the complex material you learn from other sophisticated projects to replicate in your own, attempt to minimize as much as possible. The technology stack in use by many software today is insanely huge. The more we minimize over time, the better understanding we will have of our own projects as well.
@ferinzz
@ferinzz Ай бұрын
I saw someone on another video that essentially said he has his own library of functions/ extended classes built up over the last 20 years. Along with all the issues in open source that are being found out, it seems like this would be the best route for everyone.
@heatblazer
@heatblazer Ай бұрын
61 files for such a game, come on it could fit on 2 files in C
@TheFreshMakerHD
@TheFreshMakerHD Ай бұрын
This whole building and compiling mess makes me wonder what Cherno thinks of the Zig programming language and their C/C++ build system
@electricspeedkiller8950
@electricspeedkiller8950 Ай бұрын
I was also required to do a doodle jump game. But was required to make it so they only type "main.exe 800x600" or sinilar and it runs with this resolution. Due to funny circumstances, I was extremely pressed for time, all the code wasashed into one file, didnt know how to do it other way, naming conventions out the window and so on. I also got flamed for using pointer arrays for polymorphism, because idk, i terviewer said it in such a tone that I was dumb for not knowing and it was painfully obvious why not to do it. Didnt help that classes had a "type" variable, which basically meant classes had different behavior based on this one integer value. Ah, total mess. Still got invited to interviews and missed the job as well.
@uNiels_Heart
@uNiels_Heart 23 күн бұрын
We all start out dumb and then we learn. And learning never stops (well, it will eventually, when our brain stops having the capacity to learn or when we kick the bucket, whichever happens first).
@normanklein3155
@normanklein3155 Ай бұрын
YWhy should applicants have to spend their free time creating an application for the right to interview? What other industry has such requirements? Creating an accepted application and passing the interview process doesn't provide the applicant with any additional job security as mass layoffs are still an overly frequent occurrence in high tech. One of the major reasons for such an onerous interview process is the preponderance of HB-1 candidates. These HB-1 candidates are suppose to provide necessary skills (such as provided by PhDs) that aren't locally available, but in reality only serve to drive down salaries and create the conditions for such onerous interview processes.
@marcotroster8247
@marcotroster8247 Ай бұрын
For a junior role "works on my machine" mentality is fine. Just show him how it's properly done. He's clearly self-taught and willing to learn.
@The1Wolfcast
@The1Wolfcast Ай бұрын
too bad no one wants to hire juniors anymore unless they got 30+ years experience and personally developed C++ with Bjarne himself 😭
@marcotroster8247
@marcotroster8247 Ай бұрын
@@The1Wolfcast Just transition to Rust or Go then. Or write C++ extensions for Python. There's plenty of demand for performance.
@not_ever
@not_ever Ай бұрын
Works on my machine is not even acceptable for a university assignment.
@severgun
@severgun Ай бұрын
He did build scripts but did not test them on VM or docker. That is the lesson.
@marcotroster8247
@marcotroster8247 Ай бұрын
@@not_ever Indeed. For an assignment the program has to work. At least if the supervisor isn't even too lazy to execute the code.
@jibreelkeddo7030
@jibreelkeddo7030 Ай бұрын
This comment section is kind of awful. Are you all serious? This guy spent hours and maybe days of his life making a game for a take home interview and he deserves a no response no reply rejection? Is this not a human being here? Asking someone for days of work and then just ghosting him? Unless I misunderstood the intro…. The poor guy didn’t even realise he was being rejected for build issues. The prospective employer here should have responded plainly saying build didn’t work and that “weak portability” is a deal breaker. Any less warning/clarification on this than that is immoral.
@y4ni608
@y4ni608 Ай бұрын
its crazy how everyone knows how to do it better than this guy constantly flaming him
@paradoxicalcat7173
@paradoxicalcat7173 28 күн бұрын
You are not alone! It's an insult to be asked to produce such work, only for them to essentially not be bothered to get it working! I'm happy to submit examples of work, but I won't sit and create full projects just for an interview.
@surfacing3579
@surfacing3579 Ай бұрын
If you're using CMake at all, you really should take the time to thoroughly learn it, treat it like the scripting language that it is. Even if it can be confusing at times, it is powerful, you can use it to detect the OS, run console commands, download a package manager, build and install dependencies, convert binary files to C headers, etc. all chained off just by configuring/building the project.
@stevebob240
@stevebob240 25 күн бұрын
He could have done better, but the fact he made all this just at a chance to get an interview is at least worth something. It's tough to get an interview these days.
@TheArcV
@TheArcV 15 күн бұрын
If the task of the interviewer was to obtain a sample game, the tooling parameters of that game should have been very specific: build it a specific way and for a specific platform using a specific IDE and release. With a one step build script.
@raq1024
@raq1024 Ай бұрын
before sending it to a reviewer send it to a friend or someone and ask them to build/run it - easiest way to avoid such mistakes
@and_then_I_whispered
@and_then_I_whispered Ай бұрын
22:36 I laughed so hard at this part, lol.
@TheFreshMakerHD
@TheFreshMakerHD Ай бұрын
Classic "but it works on my machine"
@valdimer11
@valdimer11 Ай бұрын
That face after finally building it. 😂. That pretty much sums it up. If the interviewer went above and beyond like you did just to end up with that??? Yeah, you werent harsh.
@moamber1
@moamber1 Ай бұрын
Do not, ever, write any code for a "future employer".
@NeUrOmAnCeRAI
@NeUrOmAnCeRAI Ай бұрын
I agree not up to par. In a competitive world this is not good enough.
@scififan698
@scififan698 Ай бұрын
exactly.
@abuDA-bt6ei
@abuDA-bt6ei 24 күн бұрын
Then it must be over for you
@etaosin
@etaosin 8 күн бұрын
You're not harsh; you're honest! And everything you say is true, so I'm also going to start a new project using your advices. If this documentation is useless for someone intending to run your repository, how likely is it that you'll be seen as a potential team member? Teamwork is about explaining your needs and getting explanations from others.
@user-kx5nr9hz2t
@user-kx5nr9hz2t Ай бұрын
This video explains why i have a windows virtual machine in a windows machine
@br3nto
@br3nto Ай бұрын
25:24 Yep. Is a do not hire.
@fireballgfx
@fireballgfx 26 күн бұрын
Sometimes code reviews are hard, but that's the only way to learn. Anyone who makes fun of this now - be quiet.
@rbaleksandar
@rbaleksandar 13 күн бұрын
Throw in some clean code, easy-to-follow build steps, some CI, basic testing and static code analysis and decent documentation (incl. generated one but not only!) and you will probably already be in the top 10-20% of all candidates you are competing against. Even if I do legacy stuff I still try to keep track of new tech that becomes popular (this is how I got into DevOps incl. IaC (infrastructure as code for cloud management, and MLOps for AI training, packaging and deployment of AI models) because your next employer will probably not be looking for someone, who needs to be educated on basic stuff.
@Saturate0806
@Saturate0806 Ай бұрын
crazy that you run random scripts without being in a VM
@MrDasfried
@MrDasfried Ай бұрын
Maybe thats a non issue when you look what the Do first? Its no magic after All
@michaeldamolsen
@michaeldamolsen Ай бұрын
@@MrDasfried "Maybe thats a non issue when you look what the Do first? Its no magic after All" - The recent xz utils backdoor begs to differ.
@paradoxicalcat7173
@paradoxicalcat7173 28 күн бұрын
You implicitly trust the developer not to have provided source code to a virus! The build environment being hostile is the least of your worries.
@mjthebest7294
@mjthebest7294 Ай бұрын
You should do a code review of the Handmade Hero project, that would be pretty fun to see lol
@px2059
@px2059 Ай бұрын
I'm confused that people are saying he roasted the code too much. What code? there was no code lol.
@-Kailinn-
@-Kailinn- Ай бұрын
No, you're not being too harsh. If people want a job it's a necessity.
@paipai762
@paipai762 Ай бұрын
when the teacher hits you with a "breaks my heart" ooof
@Lorofol
@Lorofol Ай бұрын
Man this seemed really harsh but I think it was just your tone of voice. The only way this guy would KNOW these things is to gain experience amongst other programmers. It's all good to say he's doing something against the grain or not streamlined to industry standards but this video could have been a lot more constructive, how else are we as humans supposed to learn from each other? I've been learning a lot lately about how to mentor my juniors and there is certainly a fine line to balance between coming across as an asshole when giving harsh feedback, and being constructive and acting like a cheerleader for your colleagues. Still really appreciate your code review videos though Cherno
@rrutter81
@rrutter81 23 күн бұрын
you're not harsh at all. shit should just build or move on. if anything, you spent way too much time on it. im impressed by your patience
@JonasHertzman
@JonasHertzman 24 күн бұрын
Fantastic video! This highlights exactly what I hate about c++ and why I switched to c# as my main programming language.
@user-ov3ef2eo1j
@user-ov3ef2eo1j 23 күн бұрын
Oh, my, man! It is so insane! I have no idea at all how he did it. What way did you take, warrior? The most important rule of a programmer is to think about the user. How to make it as easy as possible for him to launch the application. He must not run one thousand scripts in special order. It must to be very simple. Of course, no one will give you offer for job. You must to remake it.
@duramirez
@duramirez 26 күн бұрын
Even if an interviewer were like, ok let me try to run these scripts, in the FIRST error message, he would be like: ok I am done, nothing to see here. 😆
@velho6298
@velho6298 Ай бұрын
I would imagine whoever reviewed this by the company tripped up when the stuff just didn't work and moved on
@thomasjespersen2399
@thomasjespersen2399 Ай бұрын
Over-engineered for the project he was trying to submit, but then again, who knows what position he was interviewing for. Cool that it can (maybe?) build for a couple of Linux Distros. Most interviewers will probably want to see you implement the most simple, efficient solution to your code test. Not a "I am going to implement everything to my knowledge about this language/build system" approach, IMO.
@jamesramirez988
@jamesramirez988 28 күн бұрын
I'm a beginner and haven't made any projects. I'm wondering why the interviewer would have to build at all. Can't the programmer build and make a executable of the game that the interviewer can just download and run by itself?
@gagaxueguzheng
@gagaxueguzheng 7 күн бұрын
I use MacOS at work. Others might use Windows or Linux. They may use intel or arm cpus. Depending on that, the compilation has to be different. One could provide a VM, I'm not sure but if it was for an assignment, I'd ask this in advance and just build for the specific OS and architecture. But this is a self-taught programmer with maybe not too much experience. He'll learn a lot by this review. Hope he doesn't get discouraged by this.
@davidpatry4195
@davidpatry4195 26 күн бұрын
This is good critical feedback. True love is not about being nice. Well done Cherno.
@TormodSteinsholt
@TormodSteinsholt 19 күн бұрын
This handover has "not my job" written all over it. Anything that falls outside of allowing a player to play the game once it is finished building.
@ColinBroderickMaths
@ColinBroderickMaths Ай бұрын
They should have just asked the interviewer to install SDL2 manually and then provided a raw VS solution. I would accept that from a junior. I know they don't know everything yet. By unnecessarily over-complicating it with very bad use of PowerShell and CMake, they drew an awful lot of negative attention to things they are bad at.
@atiedebee1020
@atiedebee1020 Ай бұрын
17:26 fun fact: the C++11 standard actually specified a garbage collection API (removed in C++23, i dont think anyone actually implemented and used it)
@theantonlulz
@theantonlulz Ай бұрын
At some point you have to be able to put yourself in the interviewer's shoes in terms of how cumbersome getting a project running is. I would never in a million years think of submitting anything that would require more than a single command to run, much less six different scripts.
@yaseenkhattak1845
@yaseenkhattak1845 26 күн бұрын
Well lets hope Demitro watched the video and will fix the problems with his code, good luck :3
@UhGoomba
@UhGoomba Ай бұрын
Good timing for reviving the series, especially with the simd stuff. Hope this continues
@AllExistence
@AllExistence Ай бұрын
You done goofed, Dmitro.
@yairlevi8469
@yairlevi8469 Ай бұрын
Honestly, the same way you should start your project with blank boilerplate and already deploy it, you should start by writing the build process, and treat it as if it should be a test to be passed for the program to be considered "working properly".
@ghobashi2000
@ghobashi2000 Ай бұрын
Harsh scary review, but helpful Thanks for your precious time.
@captvimes
@captvimes 16 күн бұрын
also was he applying for a job in a gaming company because if not that is not going to help him at all
@FS-fx1it
@FS-fx1it Ай бұрын
Hurts to watch this video, I feel you @TheCherno - as CS lecturer myself I would not even go as far as try to make it run. Such a project would be an immediate fail.
@abuDA-bt6ei
@abuDA-bt6ei 24 күн бұрын
Well you lecture cs so you’ve already failed.
@Jergos
@Jergos Ай бұрын
The build system highlights the knowledge level of a candidate with respect to software engineering. I have worked with many developers who don't understand how software is organized and combined. In my experience, build knowledge almost always relates to the quality and organization of the code that the developer produces. I believe this because working with build systems requires lots of reading documentation, knowledge of how systems and components communicate, definition of protocols and data interchange formats, and writing documentation. Without some basic knowledge about how basic software works, my guess is that this leads to a developer repeating the mistakes of others. If people don't understand what CMake, Meson, Bazel, are doing, I really don't expect them to be able to understand the ever increasingly large and evolving C++ Standard.
@paradoxicalcat7173
@paradoxicalcat7173 28 күн бұрын
You want a build expert, not a developer. I learned C back in the mid 1990s, and ran build and link manually from the command line. I understand very well how the system goes together. Modern build environments are bloated crap, like pretty much everything else.
@vvitek5992
@vvitek5992 Ай бұрын
What a mess... Simple cmake script (with presets) and vcpkg/conan would be enough for this small project
@allocator7520
@allocator7520 Ай бұрын
Imagine getting tasked to make doodle jump 💀for a job
@stevebob240
@stevebob240 25 күн бұрын
For the possibility of an interview, to then get ghosted. 💀*
@allocator7520
@allocator7520 24 күн бұрын
@@stevebob240 nah 💀take my game engine dont have time to make useless shit anyway
@TwstedTV
@TwstedTV Ай бұрын
Just watching this unfold, I already have a headache. And now understand why this person didn't get the job. 🤷‍♀
@uNiels_Heart
@uNiels_Heart 23 күн бұрын
I don't think it's the best idea to use scripts of any kind to build and string together sub-projects if you're already using CMake. CMake is perfectly capable of iterating over sub-projects, build them and combine them into the end product. (While personally I'm not really fond of CMake, it is very powerful and can totally manage/build/test your whole project or your umbrella project of sub-projects or even sub-sub-projects.)
@kiyasuihito
@kiyasuihito Ай бұрын
I'd like to formally request a C++/CLI video. That would be dope! 🎉
@RMDragon3
@RMDragon3 Ай бұрын
Job interviews are basically a greedy algorithm where interviewers try to find a good candidate in as little time as possible. Fully evaluating and comparing all candidates would take way too much time. If interviewers find something like this, they are likely to reject whoever submitted it. Of course, someone MIGHT be an excelent programmer despite making it so difficult to compile their code. However, it seems more likely that there is someone better further down the list. Wasting the interviewers' time is the best way to get rejected.
Real-Time Air Traffic Control Game! // Code Review
36:50
The Cherno
Рет қаралды 92 М.
WHY did this C++ code FAIL?
38:10
The Cherno
Рет қаралды 250 М.
Comfortable 🤣 #comedy #funny
00:34
Micky Makeover
Рет қаралды 17 МЛН
Harley Quinn's revenge plan!!!#Harley Quinn #joker
00:59
Harley Quinn with the Joker
Рет қаралды 24 МЛН
Door closers: ubiquitous, yet unloved and often maladjusted
23:39
Technology Connections
Рет қаралды 304 М.
Linus Torvalds: Speaks on Hype and the Future of AI
9:02
SavvyNik
Рет қаралды 169 М.
He Didn’t Know My Mom is a Chess Grandmaster…
5:55
Anna Cramling
Рет қаралды 56 М.
Harder Than It Seems? 5 Minute Timer in C++
20:10
The Cherno
Рет қаралды 166 М.
The Bingo Paradox: 3× more likely to win
30:15
Stand-up Maths
Рет қаралды 364 М.
Clean Code is SLOW But REQUIRED? | Prime Reacts
28:22
ThePrimeTime
Рет қаралды 300 М.
SOME UNIQUE C++ CODE! // Pacman Clone Code Review
26:42
The Cherno
Рет қаралды 270 М.
Turns out REST APIs weren't the answer (and that's OK!)
10:38
Dylan Beattie
Рет қаралды 145 М.
Why is everyone LYING?
7:56
NeetCodeIO
Рет қаралды 235 М.
Japanese web design: weird, but it works. Here's why
11:49
Phoebe Yu
Рет қаралды 499 М.